Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UrlService] Back button with redirect endpoint doesn't work #116313

Closed
Dosant opened this issue Oct 26, 2021 · 0 comments · Fixed by #117155
Closed

[UrlService] Back button with redirect endpoint doesn't work #116313

Dosant opened this issue Oct 26, 2021 · 0 comments · Fixed by #117155
Labels
bug Fixes for quality problems that affect the customer experience Feature:SharingURLs Short URLs and Share URL features impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort

Comments

@Dosant
Copy link
Contributor

Dosant commented Oct 26, 2021 •
edited
Loading

Kibana version: 8.0

Describe the bug:

Navigations via newly introduced url locators can break back button

Steps to reproduce:

  1. Navigate via redirect endpoint, e.g. through search sessions: [data.search.session] Use locators instead of URL generators #115681
  2. Try back button in the browser, it doesn't work

Expected behavior:

Back button works

Any additional context:

I think we need to use replace here:

kibana/src/plugins/share/public/url_service/redirect/redirect_manager.ts

Line 69 in 3d47a03

.navigate(migratedParams)

cc @streamich
@Dosant Dosant added bug Fixes for quality problems that affect the customer experience Feature:SharingURLs Short URLs and Share URL features Team:AppServicesUx labels Oct 26, 2021
@Dosant Dosant mentioned this issue Oct 26, 2021
Merged
12 tasks
@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort and removed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort loe:medium Medium Level of Effort labels Oct 28, 2021
@jloleysens jloleysens mentioned this issue Nov 2, 2021
Merged
1 task
@exalate-issue-sync exalate-issue-sync bot changed the title [UrlService] Back button with redirect endpoint doesn't work [UrlService] Back button with redirect endpoint doesn't work Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:SharingURLs Short URLs and Share URL features impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Share] The redirect app path should not appear in the browser history jloleysens/kibana
1 participant
@Dosant