Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Share] The redirect app path should not appear in the browser history #117155

Merged
merged 4 commits into from
Nov 3, 2021
Merged

[Share] The redirect app path should not appear in the browser history #117155

merged 4 commits into from
Nov 3, 2021

Conversation

jloleysens
Copy link
Contributor

Summary

Closes #116313

Per the title.

Checklist

  • Updated unit test

@jloleysens jloleysens added Feature:SharingURLs Short URLs and Share URL features v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v8.1.0 Team:AppServicesUx v7.16.1 labels Nov 2, 2021
@jloleysens jloleysens requested a review from a team as a code owner November 2, 2021 15:39
@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Test Failures

  • [job] [logs] Default CI Group #12 / detection engine api security and spaces enabled Detection exceptions data types and operators Rule exception operators for data type long "is" operator should filter 4 long if all are set as exceptions

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
share 53.8KB 53.8KB +13.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jloleysens jloleysens merged commit 6c855f7 into elastic:main Nov 3, 2021
@jloleysens jloleysens deleted the locators/fix-history-behaviour-for-redirect-app branch November 3, 2021 13:31
@jloleysens jloleysens mentioned this pull request Nov 3, 2021
Merged
jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 3, 2021
@jloleysens
[Share] The redirect app path should not appear in the browser history (
fe50968 
elastic#117155)

* the redirect app path should not appear in the browser history

* updated jest test to also expect replace

* added comment

* update jest test
@jloleysens jloleysens mentioned this pull request Nov 3, 2021
Merged
jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 3, 2021
@jloleysens
[Share] The redirect app path should not appear in the browser history (
19517a1 
elastic#117155)

* the redirect app path should not appear in the browser history

* updated jest test to also expect replace

* added comment

* update jest test
jloleysens added a commit that referenced this pull request Nov 3, 2021
@jloleysens
[Share] The redirect app path should not appear in the browser history (
ba7667e 
#117155) (#117309)

* the redirect app path should not appear in the browser history

* updated jest test to also expect replace

* added comment

* update jest test
jloleysens added a commit that referenced this pull request Nov 3, 2021
@jloleysens
[Share] The redirect app path should not appear in the browser history (
ea7c26d 
#117155) (#117310)

* the redirect app path should not appear in the browser history

* updated jest test to also expect replace

* added comment

* update jest test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadimkibana vadimkibana vadimkibana approved these changes

@Dosant Dosant Awaiting requested review from Dosant

Assignees
No one assigned
Labels
Feature:SharingURLs Short URLs and Share URL features release_note:skip Skip the PR/issue when compiling release notes v7.16.1 v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UrlService] Back button with redirect endpoint doesn't work
3 participants
@jloleysens @kibanamachine @vadimkibana