Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover][KEYBOARD]: Documents selected button should receive keyboard focus when the popover menu is closed #121347

Closed
Tracked by #85965
1Copenut opened this issue Dec 15, 2021 · 7 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Discover Discover Application impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Project:Accessibility Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. upstream WCAG A

Comments

@1Copenut
Copy link
Contributor

1Copenut commented Dec 15, 2021

Steps to reproduce

  1. Log into a Kibana instance with the Discover data grid turned on
  2. Navigate to the data grid and check two or three document checkboxes with the SPACE key
  3. SHIFT + TAB to the button "3 documents selected" and press ENTER to open the menu
  4. Press ESC to close the meu. Press TAB a few more times to verify focus was returned to the top of the page.

Screen Shot 2021-12-15 at 1 14 54 PM


Screen Shot 2021-12-15 at 1 15 13 PM

Actual Result

  • Focus is set on the body tag at the top of the page

Expected Result

  • Focus should be set back to the "3 documents selected" button on menu close

Relevant WCAG Criteria:
Understanding Success Criterion 2.4.3: Focus Order- Level A

@1Copenut 1Copenut added Feature:Discover Discover Application Project:Accessibility WCAG A Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Dec 15, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@1Copenut 1Copenut changed the title [Discover] Documents selected button should receive keyboard focus when the popover menu is closed [Discover][KEYBOARD]: Documents selected button should receive keyboard focus when the popover menu is closed Dec 16, 2021
@kertal
Copy link
Member

kertal commented Dec 17, 2021

Thx, yes, let's fix this

@kertal kertal added the bug Fixes for quality problems that affect the customer experience label Dec 17, 2021
@jughosta jughosta self-assigned this Apr 4, 2022
@jughosta
Copy link
Contributor

jughosta commented Apr 4, 2022

This issue was already reported in EUI elastic/eui#5404

We could fix it in Discover but I think we better wait for a fix in EUI.

@kertal
Copy link
Member

kertal commented Apr 11, 2022

Oh, it was already fixed by @constancecchen , great! So I'm relabeling this upstream, we should close it when the fix is available in Kibana

@timductive timductive added the impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. label Apr 27, 2022
@jughosta
Copy link
Contributor

jughosta commented May 3, 2022

Looks good now, closing the issue.

@jughosta jughosta closed this as completed May 3, 2022
@jughosta
Copy link
Contributor

jughosta commented May 3, 2022

Thanks, @constancecchen 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Discover Discover Application impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Project:Accessibility Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. upstream WCAG A
Projects
None yet
5 participants