Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility: Magnifying Glass Icons in Discovery Field Chooser Missing screen reader text #12635

Closed
aphelionz opened this issue Jul 1, 2017 · 0 comments · Fixed by #12681
Closed

Accessibility: Magnifying Glass Icons in Discovery Field Chooser Missing screen reader text #12635

aphelionz opened this issue Jul 1, 2017 · 0 comments · Fixed by #12681
Assignees
@timroes
Labels
Project:Accessibility

Comments

@aphelionz
Copy link
Contributor

The following buttons in the screenshot need alt or aria-label attributes.

image
@cjcenizal cjcenizal mentioned this issue Jul 1, 2017
Closed
21 tasks
@aphelionz aphelionz changed the title Accesibility: Maginifying Glass Icons in Discovery Field Chooser Misisng screen reader text Accessibility: Magnifying Glass Icons in Discovery Field Chooser Missing screen reader text Jul 1, 2017
@timroes timroes self-assigned this Jul 6, 2017
timroes added a commit to timroes/kibana that referenced this issue Jul 6, 2017
@timroes
Add labels to magnifiers in field filter (Fix elastic#12635)
e5d6fd6
@timroes timroes mentioned this issue Jul 6, 2017
Merged
timroes added a commit that referenced this issue Jul 12, 2017
@timroes
Fix several a11y issues in the discover app (#12681)
bdcbdc9 
* Fix minor a11y issues in field filter

aria-expanded is a true/false/undefined state so we need to make sure
even if showFilter is undefined, we will print false (that's why the
double negation)

aria-haspopup doesn't really fit, since this is not a popup in the sense
the ARIA standard describes ("A popup is generally presented visually as
a group of items that appears to be on top of the main page content.")

Add aria-controls to reference the controlled element.

Fix #12638 and toggle label when filter toggles

* Add labels to magnifiers in field filter (Fix #12635)

* Add search role for discover search (Fix #12642)

* Describe the search input with the lucene query syntax link

* Make collapsible-sidebar a11y (Fix #12636)

* Fix id to use camel-case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timroes timroes

Labels
Project:Accessibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve the accessibility of the Discover screen timroes/kibana
2 participants
@aphelionz @timroes