-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Meta] [Guided onboarding] Open issues #144458
Comments
Pinging @elastic/platform-onboarding (Team:Journey/Onboarding) |
Thanks for the feedback @osmanis!
This has not be implemented yet. Should be addressed with #143917
I think this concern came up before (#142185 (comment) ), and we decided "Next" was appropriate. @kellyemurphy can you take a look again and weigh in here? @stephmilovic @xcrzx can you both take a look at the feedback regarding the alert/rules tours? Thanks! |
Instead of "Okay", how about we go with "Got it"? |
@osmanis Not sure I understand what you mean. What would be the expected behavior?
We've agreed previously with @gavinwye that there should be only two steps and no Okay button. Could you please align on that before I make any changes? @gavinwye, Have you had a chance to review the guided onboarding implementation in the rules area? It would be awesome to collect all feedback in one place. |
We're adding a "Next" button (as originally designed) to the rules selection pages. This Next button will filter the table to show the rule. Clicking next will advance to another tour component that will point to the rule toggle to enable it. I've collated all my feedback in this Figjam file https://www.figma.com/file/TxPRM8hdV4xPjDuf6OEFBp/Guided-onboarding-feedback-v2?node-id=0%3A1 There are some differences in the content of the tour that's in |
…area (#145223) **Related to: #144016 ## Summary This follow-up PR addresses guided onboarding feedback mentioned [here](elastic/security-team#5386) and [here](#144458). To summarize: - We're keeping the first step (install prebuilt rules) intact, but most users wouldn't see it as the rules are installed automatically during previous stages. This step is needed to cover edge cases when rules were deleted for some reason. - We're splitting the second step into two: 1) search the first rule and 2) activate it. - We're adding "Next" buttons to these steps. - For the search step, the "Next" button will automatically filter the rules table, so the first rule becomes visible. - For the activate step, the "Next" button automatically activates the first rule. - The "Next" button stays optional; we still automatically progress the guide once user actions satisfy certain conditions, like the user filtered the rules table manually or activated the first rule by clicking its toggle.
I believe all the feedback has been addressed here. Feel free to open up separate issues if you find anything outstanding. |
This is a list of open issues related to guided onboarding for 8.6.
SIEM Guide
Next
button. I think this should sayOkay
instead since there's no other tour step here. (fixed with [Guided onboarding] Update EuiTour button label #144577)Okay
button. I think we should remove the step icons and have anOkay
button to dismiss it.<img width="400" alt="Screen Shot 2022-11-02 at 12 29 45 PM" src="https://user-images.githubusercontent.com/43759819/19
9552041-d91b6996-115d-4648-8644-8ec5c65ecd75.png">
Kubernetes Guide
Next
button. I think this should sayOkay
instead since there's no other tour step here. (Fixed with [Guided onboarding] Update EuiTour button label #144577)Search Guide
TBD
@alisonelizabeth @yuliacech
The text was updated successfully, but these errors were encountered: