Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AO] Use the same bucketSize for Alert Summary Widget on the Overview page #150290

Closed
maryam-saeidi opened this issue Feb 6, 2023 · 1 comment · Fixed by #150453
Closed

[AO] Use the same bucketSize for Alert Summary Widget on the Overview page #150290

maryam-saeidi opened this issue Feb 6, 2023 · 1 comment · Fixed by #150453
Assignees
Labels
Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.7.0

Comments

@maryam-saeidi
Copy link
Member

📝 Summary

The overview has a bucketSize used for all the charts on the overview page; we need to use the same bucketSize for the Alert Summary Widget component.
Also, since we use different date formats for the tooltip, we need to decide which one is better for this purpose and use that one for all the charts. 2 options are:

  • niceTimeFormatByDay from charts library
  • UI setting 'dateFormat:scaled'

✅ Acceptance Criteria

  • Use the same bucketSize for all the charts on the overview page
  • Use the same dateFormat for all chart's tooltip
@maryam-saeidi maryam-saeidi added Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.7.0 labels Feb 6, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

@maryam-saeidi maryam-saeidi changed the title [AO] Alert Summary Widget - improve [AO] Use the same bucketSize for Alert Summary Widget on the Overview page Feb 6, 2023
@maryam-saeidi maryam-saeidi self-assigned this Feb 7, 2023
maryam-saeidi added a commit that referenced this issue Feb 14, 2023
Resolves #150290

## Summary

- Reuse the overview bucket size in AlertSummaryWidget.
- Use `scaled date format` setting instead of `niceTimeFormatter` in
observability overview charts

Before

![image](https://user-images.githubusercontent.com/12370520/217490029-06fa183e-c2f2-4d86-a09d-bde77ac45e07.png)
After

![image](https://user-images.githubusercontent.com/12370520/217492571-207c27eb-e7a0-4d90-998f-7f79beca4c02.png)
maryam-saeidi added a commit to maryam-saeidi/kibana that referenced this issue Feb 22, 2023
Resolves elastic#150290

## Summary

- Reuse the overview bucket size in AlertSummaryWidget.
- Use `scaled date format` setting instead of `niceTimeFormatter` in
observability overview charts

Before

![image](https://user-images.githubusercontent.com/12370520/217490029-06fa183e-c2f2-4d86-a09d-bde77ac45e07.png)
After

![image](https://user-images.githubusercontent.com/12370520/217492571-207c27eb-e7a0-4d90-998f-7f79beca4c02.png)

(cherry picked from commit 6e58c2d)
maryam-saeidi added a commit that referenced this issue Feb 22, 2023
…#151909)

# Backport

This will backport the following commits from `main` to `8.7`:
- [[AO] Reuse overview bucket size in AlertSummaryWidget
(#150453)](#150453)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Maryam
Saeidi","email":"maryam.saeidi@elastic.co"},"sourceCommit":{"committedDate":"2023-02-14T11:20:09Z","message":"[AO]
Reuse overview bucket size in AlertSummaryWidget (#150453)\n\nResolves
#150290\r\n\r\n## Summary\r\n\r\n- Reuse the overview bucket size in
AlertSummaryWidget.\r\n- Use `scaled date format` setting instead of
`niceTimeFormatter` in\r\nobservability overview
charts\r\n\r\nBefore\r\n\r\n![image](https://user-images.githubusercontent.com/12370520/217490029-06fa183e-c2f2-4d86-a09d-bde77ac45e07.png)\r\nAfter\r\n\r\n![image](https://user-images.githubusercontent.com/12370520/217492571-207c27eb-e7a0-4d90-998f-7f79beca4c02.png)","sha":"6e58c2dba5d2e09214ee84c11c2011d1a2b23092","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:skip","Team:
Actionable
Observability","v8.8.0"],"number":150453,"url":"https://github.com/elastic/kibana/pull/150453","mergeCommit":{"message":"[AO]
Reuse overview bucket size in AlertSummaryWidget (#150453)\n\nResolves
#150290\r\n\r\n## Summary\r\n\r\n- Reuse the overview bucket size in
AlertSummaryWidget.\r\n- Use `scaled date format` setting instead of
`niceTimeFormatter` in\r\nobservability overview
charts\r\n\r\nBefore\r\n\r\n![image](https://user-images.githubusercontent.com/12370520/217490029-06fa183e-c2f2-4d86-a09d-bde77ac45e07.png)\r\nAfter\r\n\r\n![image](https://user-images.githubusercontent.com/12370520/217492571-207c27eb-e7a0-4d90-998f-7f79beca4c02.png)","sha":"6e58c2dba5d2e09214ee84c11c2011d1a2b23092"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/150453","number":150453,"mergeCommit":{"message":"[AO]
Reuse overview bucket size in AlertSummaryWidget (#150453)\n\nResolves
#150290\r\n\r\n## Summary\r\n\r\n- Reuse the overview bucket size in
AlertSummaryWidget.\r\n- Use `scaled date format` setting instead of
`niceTimeFormatter` in\r\nobservability overview
charts\r\n\r\nBefore\r\n\r\n![image](https://user-images.githubusercontent.com/12370520/217490029-06fa183e-c2f2-4d86-a09d-bde77ac45e07.png)\r\nAfter\r\n\r\n![image](https://user-images.githubusercontent.com/12370520/217492571-207c27eb-e7a0-4d90-998f-7f79beca4c02.png)","sha":"6e58c2dba5d2e09214ee84c11c2011d1a2b23092"}}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.7.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants