Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cases] Attachments cases activity item #152088

Closed
adcoelho opened this issue Feb 24, 2023 · 5 comments
Closed

[Cases] Attachments cases activity item #152088

adcoelho opened this issue Feb 24, 2023 · 5 comments
Assignees
@adcoelho
Labels
enhancement New value added to drive a business result Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.8.0

Comments

@adcoelho
Copy link
Contributor

adcoelho commented Feb 24, 2023 •
edited by cnasikas
Loading

Subtask of #151595

Summary

Users should be able to see attachment activity in the case detail view.

Screenshot 2023-02-24 at 13 34 07

Requirements

  • The attachment activity item should display:
    • File name
    • Date Added
    • Copy reference link button
    • Actions:
      • Download
      • Delete
  • Clicking the file name on the activity item should open a modal with the file preview
@adcoelho adcoelho added enhancement New value added to drive a business result Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature v8.8.0 labels Feb 24, 2023
@adcoelho adcoelho self-assigned this Feb 24, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@adcoelho adcoelho changed the title [Cases] Activity item for attachments [Cases] Attachments cases activity item Feb 24, 2023
@adcoelho adcoelho mentioned this issue Feb 24, 2023
Closed
5 tasks
@cnasikas
Copy link
Member

What will happen to the user action when you press "Delete" from the eclipse?

@adcoelho
Copy link
Contributor Author

@cnasikas

I didn't elaborate much yet because I'm not sure this should be available in this view.

Off the top of my head, I'd say disable the buttons in this item and add a new one with User deleted attachment?

@cnasikas
Copy link
Member

cnasikas commented Feb 28, 2023 •
edited
Loading

Tracking which files are deleted to disable the buttons will put an unnecessary (at least for the MVP) burden on Cases. What about having the actions only on the modal? It will be easier because when you click to see the file the previewer will get a 404 and we can show a not found view. Adding a new "User deleted attachment" user action sounds good to me.

@adcoelho adcoelho mentioned this issue Mar 29, 2023
Merged
adcoelho added a commit that referenced this issue Apr 1, 2023
@adcoelho
[Cases] File user action in Case detail view (#153957)
0b060bd 
Fixes #152088

## Summary

Users are now able to see file activity in the case detail view.

- Image files have a different icon and a clickable file name to preview
- Other files have a standard "document" icon and the name is not
clickable
- The file can be downloaded by clicking the download icon

<img width="1456" alt="Screenshot 2023-03-29 at 17 31 06"
src="https://user-images.githubusercontent.com/1533137/228590244-c924bf2a-c5ac-47a0-ac1e-438cd089361b.png">

If the file has invalid metadata (not likely) we display the activity
item below:

<img width="808" alt="Screenshot 2023-03-29 at 17 36 25"
src="https://user-images.githubusercontent.com/1533137/228591686-0bdf4077-ddbf-4da1-9d23-67c02e969c2c.png">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adcoelho adcoelho

Labels
enhancement New value added to drive a business result Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.8.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@adcoelho @cnasikas @elasticmachine