Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infrastructure UI] Create inventory views for client service #155110

Closed
Tracked by #152617
tonyghiani opened this issue Apr 18, 2023 · 1 comment · Fixed by #155126
Closed
Tracked by #152617

[Infrastructure UI] Create inventory views for client service #155110

tonyghiani opened this issue Apr 18, 2023 · 1 comment · Fixed by #155126
Assignees
@tonyghiani
Labels
Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@tonyghiani
Copy link
Contributor

tonyghiani commented Apr 18, 2023 •
edited
Loading

📓 Summary

Part of #152617

Similarly to the LogView service created on the client, we want to create a client service to access the inventory view HTTP routes and resolve the inventory view objects.

The rest of the client-side infra plugin (e.g. the React hierarchy) as well as other plugins should use it to access inventory views. It should be available via the inventoryViews.client property on the infra plugin start contract and injected into the infra plugins KibanaContextForPlugin.

✔️ Acceptance criteria

  • Should initiate an InventoryViewsService in the infra plugin.
  • Should create an InventoryViewsClient instance in the infra plugin start contract.
  • Should expose all the available CRUD operations into the InventoryViewsClient.
  • Should inject the created client into the KibanaContextForPlugin
@tonyghiani tonyghiani mentioned this issue Apr 18, 2023
Closed
6 tasks
@botelastic botelastic bot added the needs-team Issues missing a team label label Apr 18, 2023
@tonyghiani tonyghiani self-assigned this Apr 18, 2023
@tonyghiani tonyghiani added Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services and removed needs-team Issues missing a team label labels Apr 18, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@tonyghiani tonyghiani mentioned this issue Apr 18, 2023
Merged
tonyghiani added a commit that referenced this issue Apr 26, 2023
@tonyghiani @kibanamachine
[Infrastructure UI] Create InventoryViewsService and InventoryViewsCl…
1351760 
…ient (#155126)

## 📓 Summary

Depends on #154900
Closes #155110 

This PR implements the `InventoryViewsService` and
`InventoryViewsClient`, injecting an instance of the client in the
KibanaContextForPlugin and exposing so a set of utilities to
retrieve/update inventory views:
- `findInventoryViews`
- `getInventoryView`
- `createInventoryView`
- `updateInventoryView`
- `deleteInventoryView`

## 👣 Next steps
- Implement #154725 to consume the service

---------

Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tonyghiani tonyghiani

Labels
Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Infrastructure UI] Create InventoryViewsService and InventoryViewsClient tonyghiani/kibana
2 participants
@elasticmachine @tonyghiani