Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] New Alert Page Controls should have a blank placeholder + only string controls #155414

Closed
logeekal opened this issue Apr 20, 2023 · 1 comment
Closed

[Security Solution] New Alert Page Controls should have a blank placeholder + only string controls #155414

logeekal opened this issue Apr 20, 2023 · 1 comment
Assignees
@logeekal
Labels
enhancement New value added to drive a business result Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.

Comments

@logeekal
Copy link
Contributor

logeekal commented Apr 20, 2023 •
edited
Loading

Describe the feature:

  1. Newly added Alert Page controls should have blank placeholder instead of Any
  2. User should only be able to add string Alert Page controls
@botelastic botelastic bot added the needs-team Issues missing a team label label Apr 20, 2023
@wayneseymour wayneseymour added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Apr 21, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Apr 21, 2023
@logeekal logeekal self-assigned this Apr 24, 2023
@logeekal logeekal mentioned this issue Apr 24, 2023
Merged
@logeekal logeekal added the enhancement New value added to drive a business result label Apr 24, 2023
logeekal added a commit to logeekal/kibana that referenced this issue Apr 24, 2023
@logeekal
feat: adds elastic#155414
f51513c
logeekal added a commit that referenced this issue Apr 25, 2023
@logeekal
[Security solution] Mocks and Unit tests for Alert Page controls + Ha…
8c1008f 
…ndles #155414 and #155481  (#155508)

## Summary

This PR 
- Adds unit tests and mocks for the Alert Page Controls.
- Adds feature - [Security Solution] New Alert Page Controls should have
a blank placeholder + only string controls #155414
1. For newly added controls placeholder should be blank instead of `Any`
    2. Do not allow number fields to be added as controls. 
    
    | Before | After |
    |--|--|
| <video
src="https://user-images.githubusercontent.com/7485038/233952385-79fdae88-d3a1-4bf2-abd7-a6a0fa8fb12d.mov"
/> | <video
src="https://user-images.githubusercontent.com/7485038/233955823-5b8d11f5-c3f0-409b-82ba-d50c645ca16e.mov"
/> |

- Handles [Security Solution] Alerts filters are automatically changed
#155481 and adds unit tests for the same.
   | Before | After |
   |--|--|
| <video
src="https://user-images.githubusercontent.com/7485038/233944949-7c4dac7e-4b31-46a3-9737-296729437ca0.mov"/>
| <video
src="https://user-images.githubusercontent.com/7485038/233944528-d1ddcb1a-a61d-4a96-9a19-aaa2646765e7.mov"/>
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@logeekal logeekal

Labels
enhancement New value added to drive a business result Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wayneseymour @logeekal @elasticmachine