Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] dragging a third dimension to pie chart creates incorrect state #159711

Closed
mbondyra opened this issue Jun 14, 2023 · 1 comment · Fixed by #159902
Closed

[Lens] dragging a third dimension to pie chart creates incorrect state #159711

mbondyra opened this issue Jun 14, 2023 · 1 comment · Fixed by #159902
Assignees
@mbondyra
Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@mbondyra
Copy link
Contributor

Kibana version:
main

  1. Create pie chart with one slices dimension and one metric.
  2. Drop a numeric field to the workspace.
  3. Chart is getting incorrect state that shouldn't even be considered as we didn't have multiple metrics setting on.
Screenshot 2023-06-14 at 16 55 23

Expected behavior would be to create an extra slice in this case based on the dropped field.
@mbondyra mbondyra added bug Fixes for quality problems that affect the customer experience Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Jun 14, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

@mbondyra mbondyra self-assigned this Jun 18, 2023
@mbondyra mbondyra mentioned this issue Jun 19, 2023
Merged
mbondyra added a commit that referenced this issue Jun 20, 2023
@mbondyra @stratoula
[Lens] fix pie suggestions (#159902)
4a099e1 
## Summary

Fixes #159711

When dragging a numeric field to a pie with a metric and a group already
defined, we add another metric even if `allowMultipleMetric` setting is
not set.
I fixed it by making it work the same way as a heatmap when the setting
is off - replacing metric instead. Not sure if that's a correct approach
though (should we block the suggestion whatsover?) but definitely an
improvement.

---------

Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbondyra mbondyra

Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Lens] fix pie suggestions mbondyra/kibana
2 participants
@mbondyra @elasticmachine