Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet]: Error page on navigating to Agent details page for Horde agents. #159975

Closed
amolnater-qasource opened this issue Jun 20, 2023 · 9 comments · Fixed by #160134
Closed

[Fleet]: Error page on navigating to Agent details page for Horde agents. #159975

amolnater-qasource opened this issue Jun 20, 2023 · 9 comments · Fixed by #160134
Assignees
@jillguyonnet
Labels
bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@amolnater-qasource
Copy link

Kibana Build details:

VERSION: 8.9.0 Snapshot
BUILD: 64199
COMMIT: c131f41fd4180429bfee6a9ce857dd8e3f093d94

Host OS and Browser version: All, All

Preconditions:

  1. 8.9.0 SNAPSHOT Kibana cloud environment should be available.
  2. 10-20 horde agents should be installed.

Steps to reproduce:

  1. Navigate to Fleet>Agents tab.
  2. Click any agent from the list.
  3. Observe error page on navigating to Agent details page for Horde agents.

Expected:
Error page should not be displayed on navigating to Agent details page for Horde agents.

Screen Recording:

Agents.-.Fleet.-.Elastic.-.Google.Chrome.2023-06-20.09-56-26.mp4

What's working:

  • Issue is not reproducible for actual agents.
Agents.-.Fleet.-.Elastic.-.Google.Chrome.2023-06-20.11-36-52.mp4
@amolnater-qasource amolnater-qasource added bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Fleet Team label for Observability Data Collection Fleet team labels Jun 20, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@amolnater-qasource
Copy link
Author

@manishgupta-qasource Please review.

@manishgupta-qasource
Copy link

Secondary review for this ticket is Done

@jlind23
Copy link
Contributor

jlind23 commented Jun 20, 2023

I'm not sure if that's a real bug though. Horde agents are made for our own testing purpose and thus i don't think we should prevent this page from being displayed. Did something changed recently?
cc @juliaElastic

@juliaElastic
Copy link
Contributor

I couldn't reproduce this so far.
@amolnater-qasource Could you ping me the credentials to this kibana instance?

@amolnater-qasource
Copy link
Author

Hi @juliaElastic

Thank you for looking into this.
We have shared the environment over slack.

Thanks!

@juliaElastic
Copy link
Contributor

I found that the error happens because the horde agent doesn't have components info in the /api/fleet/agents API response, and there were some changes in the agent health reporting that searches for the component status here: https://github.com/elastic/kibana/pull/158826/files#diff-aa5f8b7760477af3bff8de687573ba2e7432665546a24ea21cb4e2497612fa70R97

I think the fix is easy, we just have to add a nullcheck to the problematic line, e.g. inputStatus?.status cc @jillguyonnet

@jillguyonnet
Copy link
Contributor

Yes, that's definitely an easy fix, I can take it and add a test.

@jillguyonnet jillguyonnet self-assigned this Jun 21, 2023
@jillguyonnet jillguyonnet mentioned this issue Jun 21, 2023
Merged
5 tasks
jillguyonnet added a commit that referenced this issue Jun 22, 2023
@jillguyonnet @kibanamachine
[Fleet] Fix agent details page for agents without components (#160134)
74ba8c5 
## Summary

Fix a bug in the health reporting UI change in
#158826 where the page breaks when
the agent has no components.

Closes #159975

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@amolnater-qasource amolnater-qasource added the QA:Ready for Testing Code is merged and ready for QA to validate label Jun 26, 2023
@amolnater-qasource
Copy link
Author

Hi @jillguyonnet

Thank you for the fixes.
We have revalidated this issue on latest 8.9.0 BC3 Kibana cloud environment and found it fixed now.

Observations:

  • Error page is not visible on navigating to Agent details page for Horde agents.

Screen Recording:

Agents.-.Fleet.-.Elastic.-.Google.Chrome.2023-07-06.20-30-05.mp4

Build details:
BUILD: 64584
COMMIT: fc463b9

Hence we are marking this issue as QA:Validated.

Thanks!

@amolnater-qasource amolnater-qasource added QA:Validated Issue has been validated by QA and removed QA:Ready for Testing Code is merged and ready for QA to validate labels Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jillguyonnet jillguyonnet

Labels
bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fleet] Fix agent details page for agents without components jillguyonnet/kibana
6 participants
@elasticmachine @jillguyonnet @jlind23 @manishgupta-qasource @amolnater-qasource @juliaElastic