Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Hide embed code shortcut for serverless #161266

Closed
ThomThomson opened this issue Jul 5, 2023 · 1 comment · Fixed by #163104
Closed

[Dashboard] Hide embed code shortcut for serverless #161266

ThomThomson opened this issue Jul 5, 2023 · 1 comment · Fixed by #163104
Assignees
Labels
Feature:Dashboard Dashboard related features Feature:SharingURLs Short URLs and Share URL features impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Project:Serverless Work as part of the Serverless project for its initial release Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@ThomThomson
Copy link
Contributor

Current State
Currently, when hitting share in Dashboard (or the agg based visualize editor), the user is presented with the embed code option first.
Screen Shot 2023-07-05 at 10 17 17 AM

When clicked, this option generates a snapshot URL to this Dashboard, and wraps it in an <iframe /> with a static width and height. In order to make use of this iframe the user must:

  1. Paste it into the HTML of an existing site
  2. Host that site somewhere
  3. Allow users to log in via the iframe by changing authentication settings in kibana.yml

Problem
In serverless, users will be unable to set kibana.yml settings, making this option un-workable. We should hide this option in serverless.

@ThomThomson ThomThomson added Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:medium Medium Level of Effort Feature:SharingURLs Short URLs and Share URL features impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. labels Jul 5, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@ThomThomson ThomThomson added the Project:Serverless Work as part of the Serverless project for its initial release label Jul 5, 2023
@nreese nreese self-assigned this Jul 18, 2023
nreese added a commit that referenced this issue Aug 8, 2023
…s' (#163104)

Closes #161266

### Overview
PR hides 'Embed code' share option in serverless

### Test
* Start kibana with `yarn start --serverless=es`
* verify 'Embed code' is not displayed in Dashboard share option

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
bryce-b pushed a commit to bryce-b/kibana that referenced this issue Aug 9, 2023
…s' (elastic#163104)

Closes elastic#161266

### Overview
PR hides 'Embed code' share option in serverless

### Test
* Start kibana with `yarn start --serverless=es`
* verify 'Embed code' is not displayed in Dashboard share option

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Dashboard Dashboard related features Feature:SharingURLs Short URLs and Share URL features impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Project:Serverless Work as part of the Serverless project for its initial release Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
3 participants