Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard Navigation] Add optional icons to links #165404

Closed
Heenawter opened this issue Aug 31, 2023 · 7 comments
Closed

[Dashboard Navigation] Add optional icons to links #165404

Heenawter opened this issue Aug 31, 2023 · 7 comments
Labels
Feature:Dashboard Dashboard related features impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Project:Dashboard Navigation Related to the Dashboard Navigation Project Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@Heenawter
Copy link
Contributor

Note
This issue was raised as a result of user testing.

Describe the feature:

Some users in our testing mentioned that the links panel did not stand out very much - it would be nice to be able to optionally add icons beside each link (either the dashboard or URL icon, depending on the link type) in the panel to draw attention to them + differentiate between the link types. This should (probably?) be a panel-level setting.

The LOE is small because I'm assuming we are only supporting icon types based on the link type - if we want to support custom icons, that would significantly impact the LOE.

@Heenawter Heenawter added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:small Small Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Project:Dashboard Navigation Related to the Dashboard Navigation Project labels Aug 31, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@Heenawter Heenawter added the Feature:Dashboard Dashboard related features label Aug 31, 2023
@nickpeihl
Copy link
Member

What should be the default setting for icons?

IMO, the primary case for Links is supporting Dashboard links, and I think most users may only create Dashboard links. External links might not get created very often which limits the need to differentiate. Also, icons will take up more space on a screen which may not be wanted. So I think we could default to not showing icons and provide an EuiSwitch in the create/edit flyout to toggle icons for links.

Also, I think it just makes sense to only support the Eui icons dashboardApp and link, respectively for the initial MVP. If necessary, we can add support for custom icons in a future release.

@ThomThomson
Copy link
Contributor

I'd say we should hold off on adding icons at all for the first few releases, until / unless we know that users want custom icons. Showing only Dashboard / External link icons doesn't give much additional information IMO.

@nickpeihl
Copy link
Member

Maybe at least we should at least add support for the external icon for links that open in a new tab. This includes all external links and optionally dashboard links. #165771

That may help with some differentiation.

@nickpeihl
Copy link
Member

I suspect users could make use of emojis in the link labels to fulfill this need.

image

🙇‍♂️ to @jsanz for providing this idea.

@Heenawter
Copy link
Contributor Author

That's beautiful 🤩 Great idea, @jsanz!! Are we comfortable closing this issue then? cc @teresaalvarezsoler

@Heenawter
Copy link
Contributor Author

Heenawter commented Nov 9, 2023

Closing this for now - using emojis is a great (and simple!) way to add visual interest, and I'm not sure how much use a "Show link type" style toggle would actually get.... I worry that this would be redundant for most use cases, since dashboard linking will likely be much more common than external links.

We can re-open this based on user feedback + telemetry (which could be used to verify if my assumptions above are correct), if necessary.

@Heenawter Heenawter closed this as not planned Won't fix, can't repro, duplicate, stale Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Dashboard Dashboard related features impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Project:Dashboard Navigation Related to the Dashboard Navigation Project Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

4 participants