[Dashboard navigation] Show icon on external links and Dashboard links that open in a new tab #165771
Assignees
Labels
impact:medium
Addressing this issue will have a medium level of impact on the quality/strength of our product.
loe:small
Small Level of Effort
Project:Dashboard Navigation
Related to the Dashboard Navigation Project
Team:Presentation
Presentation Team for Dashboard, Input Controls, and Canvas
Comments
nickpeihl
added
Team:Presentation
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
This was referenced Sep 5, 2023
8 tasks
|
Blocked until EUI is updated to include elastic/eui@7740aa3 ( Edit: |
6 tasks
Heenawter
added a commit
that referenced
this issue
Jan 8, 2024
Closes #165771 ## Summary This PR adds the `external` prop to links in the Link panel in the following cases: 1. A dashboard link has the "Open in new tab" setting set to `true` 2. All URLs, regardless of if the "Open in new tab" setting is set to `true` or `false` This `external` prop renders the popout icon beside the links, like so:  ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
delanni
pushed a commit
to delanni/kibana
that referenced
this issue
Jan 11, 2024
Closes elastic#165771 ## Summary This PR adds the `external` prop to links in the Link panel in the following cases: 1. A dashboard link has the "Open in new tab" setting set to `true` 2. All URLs, regardless of if the "Open in new tab" setting is set to `true` or `false` This `external` prop renders the popout icon beside the links, like so:  ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
External links and dashboard links that open in a new tab should probably include the external icon.
There doesn't seem to be an
externalprop on EuiListGroupItem, so we may have to append the icon inline.The text was updated successfully, but these errors were encountered: