Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Unified Search] Improve input fields in filter modal for long field names #166019

Closed
timductive opened this issue Sep 7, 2023 · 3 comments · Fixed by #166024
Closed

[Unified Search] Improve input fields in filter modal for long field names #166019

timductive opened this issue Sep 7, 2023 · 3 comments · Fixed by #166024
Assignees
@timductive
Labels
Feature:Unified search Unified search related tasks impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure usability

Comments

@timductive
Copy link
Member

Describe the feature:
For field names longer than 30 characters it can be difficult to see the fields and values that you are selecting in the form fields.
image (4)

Describe a specific use case for the feature:
We can increase the length of the input that is currently selected to make it easier to view the dropdown options.
@timductive timductive added usability Team:Visualizations Visualization editors, elastic-charts and infrastructure impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Feature:Unified search Unified search related tasks labels Sep 7, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@timductive
Copy link
Member Author

In the past, it looks like we solved this problem temporarily by wrapping the line, however this is less ideal in the new form because of the drag/drop multiple conditions feature.
#85320

@timductive
Copy link
Member Author

This also appears difficult to solve at the EUI level due to complexity with the virtualization and wrapping html structure elastic/eui#2082

@timductive timductive self-assigned this Sep 7, 2023
@timductive timductive mentioned this issue Sep 7, 2023
Merged
6 tasks
stratoula added a commit that referenced this issue Sep 11, 2023
@timductive @nickofthyme
@kibanamachine @stratoula
fix unified search for long field inputs (#166024)
c6770af 
## Summary

Fixes #166019


![long-field-name-input](https://github.com/elastic/kibana/assets/1280964/be343d1b-e639-4b04-9742-0bcf1e9f032d)


### Checklist

Delete any items that are not applicable to this PR.

- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: nickofthyme <nicholas.partridge@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timductive timductive

Labels
Feature:Unified search Unified search related tasks impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure usability
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix unified search for long field inputs timductive/kibana
2 participants
@timductive @elasticmachine