Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Embeddables Rebuild] Decouple Panel & Dashboard Actions from Embeddables #167890

Closed
Tracked by #167429
ThomThomson opened this issue Oct 3, 2023 · 0 comments · Fixed by #172017
Closed
Tracked by #167429

[Embeddables Rebuild] Decouple Panel & Dashboard Actions from Embeddables #167890

ThomThomson opened this issue Oct 3, 2023 · 0 comments · Fixed by #172017
Assignees
@ThomThomson
Labels
Feature:Embeddables Relating to the Embeddable system impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:medium Medium Level of Effort project:embeddableRebuild Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@ThomThomson
Copy link
Contributor

ThomThomson commented Oct 3, 2023 •
edited
Loading

Problem
There are a number of Actions registered which require an IEmbeddable as context. We cannot move away from the current Embeddables system until these actions are decoupled.

List to be provided

Potential Solution
Most of these actions don't actually rely on the entirety of an Embeddable, but actually rely on some subset of the Embeddable's functionality - that it has a way to set title and description for instance. Instead of tightly coupling all of these actions to the Embeddable framework, we can instead take an API as context which has the methods we need getTitle, setTitle, etc.
@ThomThomson ThomThomson mentioned this issue Oct 3, 2023
Open
@ThomThomson ThomThomson changed the title Decouple Actions from Embeddables [Embeddables Rebuild] Decouple Actions from Embeddables Oct 3, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Oct 3, 2023
@ThomThomson ThomThomson added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Feature:Embeddables Relating to the Embeddable system labels Oct 3, 2023
@botelastic botelastic bot removed the needs-team Issues missing a team label label Oct 3, 2023
@ThomThomson ThomThomson self-assigned this Oct 3, 2023
@ThomThomson ThomThomson added loe:medium Medium Level of Effort impact:critical This issue should be addressed immediately due to a critical level of impact on the product. labels Oct 5, 2023
@ThomThomson ThomThomson mentioned this issue Jan 10, 2024
Merged
1 task
@ThomThomson ThomThomson changed the title [Embeddables Rebuild] Decouple Actions from Embeddables [Embeddables Rebuild] Decouple Panel & Dashboard Actions from Embeddables Jan 18, 2024
@ThomThomson ThomThomson mentioned this issue Jan 18, 2024
Closed
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this issue Feb 15, 2024
@ThomThomson @nreese @CoenWarmer
[Embeddable Refactor] Create Decoupled Presentation Panel (elastic#17…
ac80263 
…2017)

Closes elastic#167426
Closes elastic#167890

Contains much of the prep work required to decouple the Embeddables system from Kibana in anticipation of its deprecation and removal.

Co-authored-by: Nathan Reese <reese.nathan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThomThomson ThomThomson

Labels
Feature:Embeddables Relating to the Embeddable system impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:medium Medium Level of Effort project:embeddableRebuild Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Embeddable Refactor] Create Decoupled Presentation Panel ThomThomson/kibana
1 participant
@ThomThomson