Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Table text alignment is broken #173902

Closed
dej611 opened this issue Dec 22, 2023 · 2 comments · Fixed by #173908
Closed

[Lens] Table text alignment is broken #173902

dej611 opened this issue Dec 22, 2023 · 2 comments · Fixed by #173908
Assignees
@dej611
Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. regression Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@dej611
Copy link
Contributor

dej611 commented Dec 22, 2023

Kibana version: 8.13.0

Describe the bug:

This seems to be a regression

text_alignment_table
@dej611 dej611 added bug Fixes for quality problems that affect the customer experience Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Dec 22, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@dej611 dej611 self-assigned this Dec 22, 2023
@stratoula stratoula mentioned this issue Jan 2, 2024
Merged
1 task
@stratoula
Copy link
Contributor

This also happens to 8.12.0. I didnt test 8.11, it can happen there too

jbudz pushed a commit that referenced this issue Jan 2, 2024
@dej611 @stratoula @kibanamachine
[Lens] Fix table alignment (#173908)
2cddc60 
## Summary

Fixes #173902

Fix issue and introduces also a unit test.


![text_alignment_table_fix](https://github.com/elastic/kibana/assets/924948/201f70cd-6fc6-41e9-bf87-8e87f9906052)


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Jan 2, 2024
@dej611
[Lens] Fix table alignment (elastic#173908)
845d7aa 
## Summary

Fixes elastic#173902

Fix issue and introduces also a unit test.

![text_alignment_table_fix](https://github.com/elastic/kibana/assets/924948/201f70cd-6fc6-41e9-bf87-8e87f9906052)

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 2cddc60)
kibanamachine referenced this issue Jan 2, 2024
@kibanamachine @dej611
[8.12] [Lens] Fix table alignment (#173908) (#174083)
c8e877a 
# Backport

This will backport the following commits from `main` to `8.12`:
- [[Lens] Fix table alignment
(#173908)](#173908)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Marco
Liberati","email":"dej611@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-01-02T12:54:07Z","message":"[Lens]
Fix table alignment (#173908)\n\n## Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/173902\r\n\r\nFix issue and
introduces also a unit
test.\r\n\r\n\r\n![text_alignment_table_fix](https://github.com/elastic/kibana/assets/924948/201f70cd-6fc6-41e9-bf87-8e87f9906052)\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Stratoula Kalafateli
<efstratia.kalafateli@elastic.co>\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"2cddc6036879380723e3c3a6b382fb84217070aa","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Visualizations","Feature:Lens","backport:prev-minor","v8.12.0","v8.13.0"],"title":"[Lens]
Fix table
alignment","number":173908,"url":"https://github.com/elastic/kibana/pull/173908","mergeCommit":{"message":"[Lens]
Fix table alignment (#173908)\n\n## Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/173902\r\n\r\nFix issue and
introduces also a unit
test.\r\n\r\n\r\n![text_alignment_table_fix](https://github.com/elastic/kibana/assets/924948/201f70cd-6fc6-41e9-bf87-8e87f9906052)\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Stratoula Kalafateli
<efstratia.kalafateli@elastic.co>\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"2cddc6036879380723e3c3a6b382fb84217070aa"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/173908","number":173908,"mergeCommit":{"message":"[Lens]
Fix table alignment (#173908)\n\n## Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/173902\r\n\r\nFix issue and
introduces also a unit
test.\r\n\r\n\r\n![text_alignment_table_fix](https://github.com/elastic/kibana/assets/924948/201f70cd-6fc6-41e9-bf87-8e87f9906052)\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Stratoula Kalafateli
<efstratia.kalafateli@elastic.co>\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"2cddc6036879380723e3c3a6b382fb84217070aa"}}]}]
BACKPORT-->

Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dej611 dej611

Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. regression Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Lens] Fix table alignment dej611/kibana
3 participants
@dej611 @elasticmachine @stratoula