Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Canceling delete operation in Role & Role Mapping grids clears item section #175836

Closed
jeramysoucy opened this issue Jan 29, 2024 · 1 comment · Fixed by #175838
Closed

Canceling delete operation in Role & Role Mapping grids clears item section #175836

jeramysoucy opened this issue Jan 29, 2024 · 1 comment · Fixed by #175838
Labels
bug Fixes for quality problems that affect the customer experience Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!

Comments

@jeramysoucy
Copy link
Contributor

Kibana version: 8.x

Describe the bug: All items are deselected on cancel of delete operation in both role mappings and roles pages. This behavior is inconsistent with other grid pages (e.g. saved objects, cases, users, rules,...), and it not typically expected by users.

Steps to reproduce:

  1. Navigate to Stack Management->Roles or Role Mappings
  2. Ensure at least 1 selectable item exists
  3. Select one or more items, click the Delete button, then cancel the operation
  4. Observe that any selected items are no longer selected

Expected behavior:
The active selection should remain unchanged after the delete operation is canceled.

Any additional context:
See comment: #175722 (review)
@jeramysoucy jeramysoucy added bug Fixes for quality problems that affect the customer experience Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! labels Jan 29, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@jeramysoucy jeramysoucy changed the title Canceling delete operation in Role & Role Mappings grids clears item section Canceling delete operation in Role & Role Mapping grids clears item section Jan 29, 2024
@jeramysoucy jeramysoucy mentioned this issue Jan 29, 2024
Merged
cee-chen added a commit that referenced this issue Jan 29, 2024
@cee-chen
[Security][EuiInMemoryTable] Replace usage of deprecated ref method w…
ba5a5c6 
…ith controlled `selection.selected` API (#175838)

Closes #175836

## Summary

**Please help us QA your affected tables to confirm that your plugin's
table selection still works as before!**

EUI will shortly be removing this deprecated ref `setSelection` method
in favor of the new controlled `selection.selected` prop. This PR
converts the Security plugin's basic usages of controlled selection and
additionally removes 2 deletion cancellation behaviors on the team's
request. There should not be any other UI/UX regressions when selecting
rows.

See also: 
- elastic/eui#7321
- #175722 (examples of basic
conversions)
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this issue Feb 15, 2024
@cee-chen @CoenWarmer
[Security][EuiInMemoryTable] Replace usage of deprecated ref method w…
8428240 
…ith controlled `selection.selected` API (elastic#175838)

Closes elastic#175836

## Summary

**Please help us QA your affected tables to confirm that your plugin's
table selection still works as before!**

EUI will shortly be removing this deprecated ref `setSelection` method
in favor of the new controlled `selection.selected` prop. This PR
converts the Security plugin's basic usages of controlled selection and
additionally removes 2 deletion cancellation behaviors on the team's
request. There should not be any other UI/UX regressions when selecting
rows.

See also: 
- elastic/eui#7321
- elastic#175722 (examples of basic
conversions)
fkanout pushed a commit to fkanout/kibana that referenced this issue Mar 4, 2024
@cee-chen @fkanout
[Security][EuiInMemoryTable] Replace usage of deprecated ref method w…
8908d1c 
…ith controlled `selection.selected` API (elastic#175838)

Closes elastic#175836

## Summary

**Please help us QA your affected tables to confirm that your plugin's
table selection still works as before!**

EUI will shortly be removing this deprecated ref `setSelection` method
in favor of the new controlled `selection.selected` prop. This PR
converts the Security plugin's basic usages of controlled selection and
additionally removes 2 deletion cancellation behaviors on the team's
request. There should not be any other UI/UX regressions when selecting
rows.

See also: 
- elastic/eui#7321
- elastic#175722 (examples of basic
conversions)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!
Projects
None yet
Milestone
No milestone
2 participants
@elasticmachine @jeramysoucy