Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Alert Detail flyout for Linux Session Alert overlaps Investigation Timeline. #180679

Closed
arvindersingh-qasource opened this issue Apr 12, 2024 · 10 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience fixed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team v8.14.0
Milestone

Comments

@arvindersingh-qasource
Copy link

Describe the bug
Alerts Detail flyout for Linux Session Alert overlaps Investigation Timeline.

Build Details

VERSION: 8.14.0
BUILD: 73235
COMMIT: 619fa44280c5d89c3f3e1fe8bf8b92ba0d343be1

Browser Details
This issue is occurring on all browsers.

Preconditions

  1. Kibana v8.14.0 must be available.
  2. Linux Session Alert must be available.

Steps to Reproduce

  1. Navigate to Security -> Alerts .
  2. Open Session View for Linux Session Alert.
  3. Open Alerts Detail flyout.
  4. Under Insights, open alerts related by source event.
  5. Click on Investigate in Timeline
  6. Observe that Alert Detail flyout for Linux Session Alert overlaps Investigation Timeline.

Actual Result
Alerts Detail flyout for Linux Session Alert overlaps Investigation Timeline.

Expected Result
Alerts Detail flyout for Linux Session Alert should not overlaps Investigation Timeline.

What's Working

  • N/A

What's Not Working

  • N/A

Screen Recording

Alerts.-.Kibana.-.Google.Chrome.2024-04-12.15-36-48.mp4
@arvindersingh-qasource arvindersingh-qasource added bug Fixes for quality problems that affect the customer experience triage_needed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.14.0 labels Apr 12, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@arvindersingh-qasource
Copy link
Author

@karanbirsingh-qasource Please review this ticket.

Thanks.

@MadameSheema MadameSheema assigned michaelolo24 and PhilippeOberti and unassigned ghost Apr 12, 2024
@MadameSheema MadameSheema added Team:Threat Hunting Security Solution Threat Hunting Team Team:Threat Hunting:Investigations Security Solution Investigations Team and removed Team:Detections and Resp Security Detection Response Team labels Apr 12, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

@PhilippeOberti
Copy link
Contributor

@arvindersingh-qasource thanks for opening this ticket! I can indeed reproduce the issue locally. The issue actually happens not only from the Session View but also from the main alerts table...

Screen.Recording.2024-04-23.at.12.50.06.PM.mov

My guess is the bug was introduced by this PR but I will take a closer look. Another reason to get rid of this old flyout... we're spending time fixing something that's going away soon :(

@PhilippeOberti
Copy link
Contributor

Actually it seems that the bug was introduced in a more recent PR that previously mentioned. Here's where we override to 1002 in the old flyout, which we shouldn't do as the timeline has a z-index of 1001 (introduced in the PR linked in my previous comment).

@PhilippeOberti
Copy link
Contributor

PhilippeOberti commented Apr 23, 2024

Ok I think I understand a bit more what's happening. The last PR opened and merged by @michaelolo24 renders the old flyout on top of timeline. This works when that flyout is opened from within timeline, but it breaks everywhere the flyout is being used from (like alerts table).

@michaelolo24 I feel like this change should be reverted and I have a PR to do so. That means that for now the new tables in timeline won't have a flyout working (unless we use the expandable flyout using the expandableTimelineFlyoutEnabled feature flag), but at least we're not breaking the primary behavior for all users in 8.14.

What this means is we NEED to use expandableTimelineFlyoutEnabled along side unifiedComponentsInTimelineEnabled to have a flyout working.

Is that ok with you?

@PhilippeOberti
Copy link
Contributor

@arvindersingh-qasource the PR to fix this issue was just merged. The fix should be available in BC3 (as BC2 was just built earlier today).

Please let me know if you confirm the fix when BC3 is available, thank you!

@ghost
Copy link

ghost commented May 6, 2024

Hi @PhilippeOberti

This issue is fixed now, validated the issue on 8.14 BC3 ✅

Build Details:

Version: 8.14
Commit: 2a492e1625f24336f3259b2b8df62b2b18127e81
Build: 73762

Screen-Shot

Screenshot 2024-05-06 at 9 46 10 AM

Hence we are closing this issue and adding "QA:Validated" tag to it.

thanks !!

@ghost ghost closed this as completed May 6, 2024
@ghost ghost added the QA:Validated Issue has been validated by QA label May 6, 2024
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience fixed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team v8.14.0
Projects
None yet
Development

No branches or pull requests

5 participants