[Security Solution][Alert details] - remove old flyout unnecessary z-index change #181480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippeOberti
added
release_note:skip
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
PhilippeOberti
force-pushed
the
old-flyout-z-index
branch
from
3255c11 to
a64d552
Compare
PhilippeOberti
commented
Apr 23, 2024
| @@ -55,7 +57,8 @@ describe( | |||
| cy.get(GET_DISCOVER_DATA_GRID_CELL_HEADER('agent.type')).should('not.exist'); | |||
| }); | |||
|
|
|||
| context('flyout', () => { | |||
| // these tests are skipped until we implement the expandable flyout in the unified table for timeline | |||
| context.skip('flyout', () => { | |||
There was a problem hiding this comment.
@michaelolo24 let me know if you're ok skipping these tests. Explanation of why I think we should do this here
There was a problem hiding this comment.
Yea, that's fine. I think the flyout in timeline being enabled will align with when the unified table is ready so no worries, we can move skip this. Fyi @logeekal
michaelolo24
approved these changes
Apr 23, 2024
PhilippeOberti
force-pushed
the
old-flyout-z-index
branch
3 times, most recently
from
ca09c4c to
50ad661
Compare
PhilippeOberti
force-pushed
the
old-flyout-z-index
branch
from
50ad661 to
e5e6572
Compare
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 25, 2024
…index change (elastic#181480) (cherry picked from commit 84e3ea5)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Apr 25, 2024
…sary z-index change (#181480) (#181784) # Backport This will backport the following commits from `main` to `8.14`: - [[Security Solution][Alert details] - remove old flyout unnecessary z-index change (#181480)](#181480) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Philippe Oberti","email":"philippe.oberti@elastic.co"},"sourceCommit":{"committedDate":"2024-04-25T21:39:50Z","message":"[Security Solution][Alert details] - remove old flyout unnecessary z-index change (#181480)","sha":"84e3ea51a8f5b8ead0abfcf40016c02d0b3c3ab2","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat Hunting:Investigations","v8.14.0","v8.15.0"],"title":"[Security Solution][Alert details] - remove old flyout unnecessary z-index change","number":181480,"url":"https://github.com/elastic/kibana/pull/181480","mergeCommit":{"message":"[Security Solution][Alert details] - remove old flyout unnecessary z-index change (#181480)","sha":"84e3ea51a8f5b8ead0abfcf40016c02d0b3c3ab2"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/181480","number":181480,"mergeCommit":{"message":"[Security Solution][Alert details] - remove old flyout unnecessary z-index change (#181480)","sha":"84e3ea51a8f5b8ead0abfcf40016c02d0b3c3ab2"}}]}] BACKPORT--> Co-authored-by: Philippe Oberti <philippe.oberti@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A big was introduced over the last few weeks, where the old alert details flyout is now shown in front of the timeline, instead of behind.
I'm not sure exactly why the
z-indexvalue was changed to1002in this recent PR, but the timelinez-indexis set to1001, so the flyout would always be shown above. The changes to the timelinez-indexwhere performed in this PR.@michaelolo24 do you know why this recent change was made? Can you help me test if you remember the scenarios that made you want to make the change in the first place?
This PR removes that
z-indexoverride, and the issue is fixed (at least in the testing I've done).Before fix
Screen.Recording.2024-04-23.at.12.50.06.PM.mov
After fix
Screen.Recording.2024-04-23.at.12.56.22.PM.mov
#180679