Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Observability stateful sidenav] Add functional tests #191509

Closed
sebelga opened this issue Aug 27, 2024 · 6 comments · Fixed by #192805
Closed

[Observability stateful sidenav] Add functional tests #191509

sebelga opened this issue Aug 27, 2024 · 6 comments · Fixed by #192805
Assignees
@mgiota
Labels
Team:obs-ux-management Observability Management User Experience Team

Comments

@sebelga
Copy link
Contributor

sebelga commented Aug 27, 2024

We need to add functional test coverage for the new side navigation in stateful. For the upcoming 8.16 release it will only be available to cloud users.

In #189804 we exposed helpers to facilitate adding test coverage. Please refer to the PR description for info on how to get started.
@sebelga sebelga added the Team:Observability Team label for Observability Team (for things that are handled across all of observability) label Aug 27, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/unified-observability (Team:Observability)

@sebelga sebelga mentioned this issue Aug 27, 2024
Closed
@paulb-elastic paulb-elastic mentioned this issue Sep 5, 2024
Closed
@jasonrhodes jasonrhodes added the Team:obs-ux-management Observability Management User Experience Team label Sep 5, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@jasonrhodes jasonrhodes removed the Team:Observability Team label for Observability Team (for things that are handled across all of observability) label Sep 5, 2024
@jasonrhodes
Copy link
Member

I've moved this to "Ready" but it needs to be heavily coordinated with the work being done in its parent issue.

@mgiota mgiota self-assigned this Oct 1, 2024
@mgiota mgiota mentioned this issue Oct 2, 2024
Merged
@mgiota
Copy link
Contributor

mgiota commented Oct 2, 2024

@sebelga I added some tests in this PR that check:

  • toggling of the panel when clicking on the link button
  • AI assistant changes
  • Infrastructure changes
  • Other Tools changes
  • Machine Learning changes

I added a new helper method clickPanelLink and I adapted the existing expectLinkExists method.

@sebelga
Copy link
Contributor Author

sebelga commented Oct 2, 2024

@mgiota Sorry but the oblt functional tests can't live there. Those tests should be maintained by your team so it is better to have a dedicated place for them. Thanks 👍

@mgiota mgiota closed this as completed in ab71509 Oct 4, 2024
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 4, 2024
@mgiota
Implement new nav hierarchy for stateful/cloud (elastic#192805)
9cdabcc 
<strike>Depends on elastic#193526,
WON'T FIX</strike>

Fixes elastic#192803
Fixes elastic#191509

This PR updates the nav hierarchy for stateful/cloud and changes the
`accordion` to `panelOpener`. The menu items have been updated according
to the Figma file and the discussions happening in this
[issue](elastic#192050). I took a video
below of how the new navigation looks like with the new changes

https://github.com/user-attachments/assets/e73c8dd9-b674-4146-bcde-443490569502

## What was changed
- AI & ML menu is removed and split into
  - `AI Assistant`
- `Machine learning`: this menu was already present in the footer, it
was moved in the body (after Infrastucture)
- `Applications` now opens a `panelOpener` instead of an `accordion`
  - Synthetics was moved to a new section
  - “User Experience” was renamed to “User experience”
- `Infrastucture` now opens a `panelOpener` instead of an `accordion`
  - Universal Profiling was moved to a separate section below
  - Metrics Explorer was renamed to Metrics explorer
- `Machine learning` now opens a `panelOpener` instead of an `accordion`
- `Supplied Configurations` was added under the Machine learning >
Anomaly Detection section.
- The machine learning `link:
'securitySolutionUI:machine_learning-landing'` was completely removed.
Clicking on the `Machine learning` link will slide out the panel instead
(same behavior with clicking on the icon). More details about why I
removed this
[here](elastic#192805 (comment))
  - Use sentence/case for the menu items
- `Other tools` now opens a `panelOpener` instead of an `accordion`
  - Logs anomalies was added here
  - Logs categories was added here
  - Visualize library was added
- Clicking on the 1st level menu items (Applications, Infrastructure,
Machine learning, Other tools) toggles the panel on the right
(arrowRight).
- The icon was changed from the four small squares to the right-facing
caret
- The sub-nav menu slides out to the right whenever the label OR the
icon are clicked
- `Getting started` in the footer was renamed to `Add data`
- `Data Set Quality` was added under `Stack Management > Data` section
below `Index Management`

## Functional Tests
Some tests have been added that test:
- toggling of the panel when clicking on the link button
- `AI assistant` changes
- `Infrastructure` changes
- `Other Tools` changes
- `Machine Learning` changes

## What this PR doesn't do
I faced some issues with the footer, so footer will be separately
handled in this [issue](elastic#192865)

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Sébastien Loix <sebastien.loix@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Dominique Clarke <dominique.clarke@elastic.co>
(cherry picked from commit ab71509)
tiansivive pushed a commit to tiansivive/kibana that referenced this issue Oct 7, 2024
@mgiota @elasticmachine
@sebelga @kibanamachine @dominiqueclarke @tiansivive
Implement new nav hierarchy for stateful/cloud (elastic#192805)
ef12deb 
<strike>Depends on elastic#193526,
WON'T FIX</strike>

Fixes elastic#192803
Fixes elastic#191509

This PR updates the nav hierarchy for stateful/cloud and changes the
`accordion` to `panelOpener`. The menu items have been updated according
to the Figma file and the discussions happening in this
[issue](elastic#192050). I took a video
below of how the new navigation looks like with the new changes



https://github.com/user-attachments/assets/e73c8dd9-b674-4146-bcde-443490569502

## What was changed
- AI & ML menu is removed and split into
  - `AI Assistant`
- `Machine learning`: this menu was already present in the footer, it
was moved in the body (after Infrastucture)
- `Applications` now opens a `panelOpener` instead of an `accordion`
  - Synthetics was moved to a new section
  - “User Experience” was renamed to “User experience”  
- `Infrastucture` now opens a `panelOpener` instead of an `accordion`
  - Universal Profiling was moved to a separate section below
  - Metrics Explorer was renamed to Metrics explorer
- `Machine learning` now opens a `panelOpener` instead of an `accordion`
- `Supplied Configurations` was added under the Machine learning >
Anomaly Detection section.
- The machine learning `link:
'securitySolutionUI:machine_learning-landing'` was completely removed.
Clicking on the `Machine learning` link will slide out the panel instead
(same behavior with clicking on the icon). More details about why I
removed this
[here](elastic#192805 (comment))
  - Use sentence/case for the menu items
- `Other tools` now opens a `panelOpener` instead of an `accordion`
  - Logs anomalies was added here
  - Logs categories was added here
  - Visualize library was added
- Clicking on the 1st level menu items (Applications, Infrastructure,
Machine learning, Other tools) toggles the panel on the right
(arrowRight).
- The icon was changed from the four small squares to the right-facing
caret
- The sub-nav menu slides out to the right whenever the label OR the
icon are clicked
- `Getting started` in the footer was renamed to `Add data`
- `Data Set Quality` was added under `Stack Management > Data` section
below `Index Management`


## Functional Tests
Some tests have been added that test:
- toggling of the panel when clicking on the link button
- `AI assistant` changes
- `Infrastructure` changes
- `Other Tools` changes
- `Machine Learning` changes


## What this PR doesn't do
I faced some issues with the footer, so footer will be separately
handled in this [issue](elastic#192865)

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Sébastien Loix <sebastien.loix@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Dominique Clarke <dominique.clarke@elastic.co>
@sebelga
Copy link
Contributor Author

sebelga commented Oct 8, 2024

@mgiota @jasonrhodes I wanted to pointed out that ideally the coverage of the side navigation links should look like in this PR from the search team.

You did add here a few tests but clearly they don't cover every link declared in the observability nav.

I leave it to you to decide if you think it would be good to add more coverage, but I wanted to share the Search PR as a reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mgiota mgiota

Labels
Team:obs-ux-management Observability Management User Experience Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement new nav hierarchy for stateful/cloud mgiota/kibana
4 participants
@jasonrhodes @mgiota @sebelga @elasticmachine