Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Controls] Fix left padding in view mode #192229

Closed
Heenawter opened this issue Sep 5, 2024 · 1 comment · Fixed by #192319
Closed

[Controls] Fix left padding in view mode #192229

Heenawter opened this issue Sep 5, 2024 · 1 comment · Fixed by #192319
Assignees
Labels
bug Fixes for quality problems that affect the customer experience good first issue low hanging fruit impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@Heenawter
Copy link
Contributor

Describe the bug:
Now that we are using compressed styling for controls, the small EuiIcon that we were using to simulate left padding in view mode (see #184533) is too large.

Image

EuiIcon doesn't have an xs option, so we might be forced to just do an empty div with an enforced width of 8px instead (to match the right padding that is now 8px from switching to compressed styling instead of the previous 16px).

Here's what that would look like:

Sep-05-2024 09-59-50

cc @cqliu1 @rshen91

See #192094 (comment) for the discussion around this.

@Heenawter Heenawter added bug Fixes for quality problems that affect the customer experience good first issue low hanging fruit impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Sep 5, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience good first issue low hanging fruit impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants