[Controls] Fix styles

[andreadelrio]

Summary

Closes #192229

Changes

• Fixes padding in the prepend in all control types, in both modes (i.e. view and edit) and in both label positions (i.e. inline and above)
• Removes the empty icon in view mode introduced by [Controls] Prevent jumping control drag handle between view modes #184533. After thinking about this is some more I think this is unnecessary given the shift in the UI that already exists for Dashboards when switching back and forth between View and Edit Mode.
• For better control, this creates and passes custom class names to controlFrame__formControlLayout.

Note

We will be able to do a further clean up these styles when we are done with #192005.

Checklist

Delete any items that are not applicable to this PR.

• Unit or functional tests were updated or added to match the most common scenarios
• Flaky Test Runner was used on any tests changed
• Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
• Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
• This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
• This was checked for cross-browser compatibility

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk	Probability	Severity	Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space.	Low	High	Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks.	High	Low	Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled.	Medium	High	Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[andreadelrio]

@elasticmachine merge upstream

[Heenawter]

This works great for the new React controls!! 🎉 Seems like some of the css changes are impacting the controls on Dashboard, though - there is extra padding in both edit mode and view mode on the left of the label text:

Main	This PR

So, we can either (a) wait until #192221 and #190561 are merged to merge this change or (b) try to make these changes without impacting the old controls.

[andreadelrio]

This works great for the new React controls!! 🎉 Seems like some of the css changes are impacting the controls on Dashboard, though - there is extra padding in both edit mode and view mode on the left of the label text:

Main This PR


So, we can either (a) wait until #192221 and #190561 are merged to merge this change or (b) try to make these changes without impacting the old controls.

My vote is to wait until #192221 and #190561 are merged.

[Heenawter]

@andreadelrio This should be good to merge now 🎉 🎉 🎉

[andreadelrio]

@elasticmachine merge upstream

[Heenawter]

Realized that, in the original compressed PR, we missed the fact that the "apply" button should also be compressed 😅

Would you mind fixing that here @andreadelrio? If not, I can make a quick follow up.

Other than that, this LGTM 👍 The above issue is technically unrelated, so approving to unblock. Just LMK.

[andreadelrio]

@elasticmachine merge upstream

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 51a16f2

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
controls	595.3KB	597.0KB	+1.7KB

History

• 💔 Build #233245 failed 38d5cf8
• 💔 Build #233235 failed b48a4a5
• 💔 Build #233213 failed 8c81905
• 💔 Build #232643 failed 1fcd634
• 💔 Build #232632 failed 52c3375

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream