Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Observability serverless nav] Change nav hierarchy using panelOpener #192804

Closed
mgiota opened this issue Sep 13, 2024 · 0 comments · Fixed by #193510
Closed

[Observability serverless nav] Change nav hierarchy using panelOpener #192804

mgiota opened this issue Sep 13, 2024 · 0 comments · Fixed by #193510
Labels
Team:obs-ux-management Observability Management User Experience Team

Comments

@mgiota
Copy link
Contributor

mgiota commented Sep 13, 2024 •
edited
Loading

Summary

This issue updates the o11y nav hierarchy for serverless and changes the accordion to panelOpener. The menu items need to be updated according to the Figma file and the discussions happening here.

Acceptance criteria

📍AC 1: Change existing navigation hierarchies for serverless
📍AC 2: Change sub-navs from "accordion" style opening to a "slide out" method instead

  • AI & ML menu should be removed and split into
    • AI Assistant
    • Machine learning: this menu didn't exist before on serverless, it is a new menu that should be added
  • Applications should open a panelOpener instead of an accordion
  • Infrastucture should open a panelOpener instead of an accordion
  • Machine learning should open a panelOpener instead of an accordion
    • Supplied Configurations should be added under the Machine learning > Anomaly Detection section.
    • Data set quality needs to be added
  • Stack Management in the footer should stay as is at the moment for consistency reasons with search and security. There is no panelOpener, just a landing page
  • Menu items should change from title case to sentence case (capital initial on the first word, followed by lowercase initials for the rest)

📍AC4: Confirm breadcrumbs work as expected
@botelastic botelastic bot added the needs-team Issues missing a team label label Sep 13, 2024
@lukasolson lukasolson added Team:obs-ux-management Observability Management User Experience Team and removed needs-team Issues missing a team label labels Sep 18, 2024
This was referenced Sep 19, 2024
Closed
Merged
@mgiota mgiota closed this as completed in 0e736e3 Nov 8, 2024
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 8, 2024
@mgiota
Implement new o11y nav hierarchy for serverless (elastic#193510)
a81ef07 
Fixes elastic#192804

This PR updates the nav hierarchy on serverless and changes the
`accordion` to `panelOpener`. The menu items have been updated according
to the [Figma
file](https://www.figma.com/design/IAR7FjBaSCDWypNYL83fzy/Observability-Navigation?node-id=1232-10087&node-type=frame&t=AMlUqaK2UhhiyqGi-0).
Here's a Video of how nav hierarchy looks like on serverless with the
new changes:

https://github.com/user-attachments/assets/55d04969-379e-4cd1-8e25-d50382cf51e0

## What was changed

- AI & ML menu is removed and split into
  - `AI Assistant`
  - `Machine learning`
- `Applications` now opens a `panelOpener` instead of an `accordion`
- `Service Inventory` was renamed to `Service inventory` to meet the use
of sentence-case requirement
  - Synthetics was moved to a new section
- `Infrastructure`
- `Infrastructure Inventory` was renamed to `Infrastructure inventory`
to match the sentence-case requirement
-  `Machine learning`: this menu was not present at all on serverless

## Notes for the Reviewer

- `Stack Management` on security and search don't use any `panelOpener`,
they use a landing page instead. In order to be consistent with the rest
solutions, I kept Stack Management as is.
- `Machine Learning` menu item was not present at all on serverless. I
need a confirmation, that it is fine to bring it in as it is from
stateful cc @vinaychandrasekhar

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit 0e736e3)
rbrtj pushed a commit to rbrtj/kibana that referenced this issue Nov 8, 2024
@mgiota @elasticmachine @rbrtj
Implement new o11y nav hierarchy for serverless (elastic#193510)
00b48a7 
Fixes elastic#192804

This PR updates the nav hierarchy on serverless and changes the
`accordion` to `panelOpener`. The menu items have been updated according
to the [Figma
file](https://www.figma.com/design/IAR7FjBaSCDWypNYL83fzy/Observability-Navigation?node-id=1232-10087&node-type=frame&t=AMlUqaK2UhhiyqGi-0).
Here's a Video of how nav hierarchy looks like on serverless with the
new changes:


https://github.com/user-attachments/assets/55d04969-379e-4cd1-8e25-d50382cf51e0

## What was changed

- AI & ML menu is removed and split into
  - `AI Assistant`
  - `Machine learning`
- `Applications` now opens a `panelOpener` instead of an `accordion`
- `Service Inventory` was renamed to `Service inventory` to meet the use
of sentence-case requirement
  - Synthetics was moved to a new section
- `Infrastructure`
- `Infrastructure Inventory` was renamed to `Infrastructure inventory`
to match the sentence-case requirement
-  `Machine learning`: this menu was not present at all on serverless 

## Notes for the Reviewer

- `Stack Management` on security and search don't use any `panelOpener`,
they use a landing page instead. In order to be consistent with the rest
solutions, I kept Stack Management as is.
- `Machine Learning` menu item was not present at all on serverless. I
need a confirmation, that it is fine to bring it in as it is from
stateful cc @vinaychandrasekhar

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Team:obs-ux-management Observability Management User Experience Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement new o11y nav hierarchy for serverless mgiota/kibana
2 participants
@lukasolson @mgiota