[Search:AppSearch:Engines:Schema page]Add a new field modal dialog missing title from announcement #201338
Assignees
Labels
defect-level-3
Moderate UX disruption or potentially confusing
Project:Accessibility
Team:Search
WCAG A
Comments
|
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
L1nBra
added
WCAG A
Team:Search
defect-level-3
alexwizp
added a commit
to alexwizp/kibana
that referenced
this issue
Nov 26, 2024
…og missing title from announcement Closes: elastic#201338
alexwizp
added a commit
that referenced
this issue
Nov 27, 2024
…og missing title from announcement (#201786) Closes: #201338 ## Description Dialog modal visible title should be announced for the users, especially using assistive technology to know what dialog modal, flyout opened. ## What was changed?: 1. aria-labelledby={modalTitleId} attribute was added for mentioned EuiModal # Screen <img width="1330" alt="Screenshot 2024-11-26 at 15 40 20" src="https://github.com/user-attachments/assets/dc5fd6e3-eaad-43c4-9f56-0eb8644789ae"> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Nov 27, 2024
…og missing title from announcement (elastic#201786) Closes: elastic#201338 ## Description Dialog modal visible title should be announced for the users, especially using assistive technology to know what dialog modal, flyout opened. ## What was changed?: 1. aria-labelledby={modalTitleId} attribute was added for mentioned EuiModal # Screen <img width="1330" alt="Screenshot 2024-11-26 at 15 40 20" src="https://github.com/user-attachments/assets/dc5fd6e3-eaad-43c4-9f56-0eb8644789ae"> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 87af12d)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Nov 27, 2024
…og missing title from announcement (elastic#201786) Closes: elastic#201338 ## Description Dialog modal visible title should be announced for the users, especially using assistive technology to know what dialog modal, flyout opened. ## What was changed?: 1. aria-labelledby={modalTitleId} attribute was added for mentioned EuiModal # Screen <img width="1330" alt="Screenshot 2024-11-26 at 15 40 20" src="https://github.com/user-attachments/assets/dc5fd6e3-eaad-43c4-9f56-0eb8644789ae"> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 87af12d)
kibanamachine
added a commit
that referenced
this issue
Nov 27, 2024
…al dialog missing title from announcement (#201786) (#201995) # Backport This will backport the following commits from `main` to `8.17`: - [fix: [Search:AppSearch:Engines:Schema page]Add a new field modal dialog missing title from announcement (#201786)](#201786) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alexey Antonov","email":"alexwizp@gmail.com"},"sourceCommit":{"committedDate":"2024-11-27T14:18:48Z","message":"fix: [Search:AppSearch:Engines:Schema page]Add a new field modal dialog missing title from announcement (#201786)\n\nCloses: #201338\r\n\r\n## Description\r\nDialog modal visible title should be announced for the users, especially\r\nusing assistive technology to know what dialog modal, flyout opened.\r\n\r\n## What was changed?:\r\n\r\n1. aria-labelledby={modalTitleId} attribute was added for mentioned\r\nEuiModal\r\n\r\n# Screen\r\n<img width=\"1330\" alt=\"Screenshot 2024-11-26 at 15 40 20\"\r\nsrc=\"https://github.com/user-attachments/assets/dc5fd6e3-eaad-43c4-9f56-0eb8644789ae\">\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"87af12d21def2ff03e47d0df59b28dfa11436fa8","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","v9.0.0","Team:Search","backport:version","v8.17.0","v8.18.0"],"title":"fix: [Search:AppSearch:Engines:Schema page]Add a new field modal dialog missing title from announcement","number":201786,"url":"https://github.com/elastic/kibana/pull/201786","mergeCommit":{"message":"fix: [Search:AppSearch:Engines:Schema page]Add a new field modal dialog missing title from announcement (#201786)\n\nCloses: #201338\r\n\r\n## Description\r\nDialog modal visible title should be announced for the users, especially\r\nusing assistive technology to know what dialog modal, flyout opened.\r\n\r\n## What was changed?:\r\n\r\n1. aria-labelledby={modalTitleId} attribute was added for mentioned\r\nEuiModal\r\n\r\n# Screen\r\n<img width=\"1330\" alt=\"Screenshot 2024-11-26 at 15 40 20\"\r\nsrc=\"https://github.com/user-attachments/assets/dc5fd6e3-eaad-43c4-9f56-0eb8644789ae\">\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"87af12d21def2ff03e47d0df59b28dfa11436fa8"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201786","number":201786,"mergeCommit":{"message":"fix: [Search:AppSearch:Engines:Schema page]Add a new field modal dialog missing title from announcement (#201786)\n\nCloses: #201338\r\n\r\n## Description\r\nDialog modal visible title should be announced for the users, especially\r\nusing assistive technology to know what dialog modal, flyout opened.\r\n\r\n## What was changed?:\r\n\r\n1. aria-labelledby={modalTitleId} attribute was added for mentioned\r\nEuiModal\r\n\r\n# Screen\r\n<img width=\"1330\" alt=\"Screenshot 2024-11-26 at 15 40 20\"\r\nsrc=\"https://github.com/user-attachments/assets/dc5fd6e3-eaad-43c4-9f56-0eb8644789ae\">\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"87af12d21def2ff03e47d0df59b28dfa11436fa8"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
kibanamachine
added a commit
that referenced
this issue
Nov 27, 2024
…l dialog missing title from announcement (#201786) (#201996) # Backport This will backport the following commits from `main` to `8.x`: - [fix: [Search:AppSearch:Engines:Schema page]Add a new field modal dialog missing title from announcement (#201786)](#201786) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alexey Antonov","email":"alexwizp@gmail.com"},"sourceCommit":{"committedDate":"2024-11-27T14:18:48Z","message":"fix: [Search:AppSearch:Engines:Schema page]Add a new field modal dialog missing title from announcement (#201786)\n\nCloses: #201338\r\n\r\n## Description\r\nDialog modal visible title should be announced for the users, especially\r\nusing assistive technology to know what dialog modal, flyout opened.\r\n\r\n## What was changed?:\r\n\r\n1. aria-labelledby={modalTitleId} attribute was added for mentioned\r\nEuiModal\r\n\r\n# Screen\r\n<img width=\"1330\" alt=\"Screenshot 2024-11-26 at 15 40 20\"\r\nsrc=\"https://github.com/user-attachments/assets/dc5fd6e3-eaad-43c4-9f56-0eb8644789ae\">\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"87af12d21def2ff03e47d0df59b28dfa11436fa8","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","v9.0.0","Team:Search","backport:version","v8.17.0","v8.18.0"],"title":"fix: [Search:AppSearch:Engines:Schema page]Add a new field modal dialog missing title from announcement","number":201786,"url":"https://github.com/elastic/kibana/pull/201786","mergeCommit":{"message":"fix: [Search:AppSearch:Engines:Schema page]Add a new field modal dialog missing title from announcement (#201786)\n\nCloses: #201338\r\n\r\n## Description\r\nDialog modal visible title should be announced for the users, especially\r\nusing assistive technology to know what dialog modal, flyout opened.\r\n\r\n## What was changed?:\r\n\r\n1. aria-labelledby={modalTitleId} attribute was added for mentioned\r\nEuiModal\r\n\r\n# Screen\r\n<img width=\"1330\" alt=\"Screenshot 2024-11-26 at 15 40 20\"\r\nsrc=\"https://github.com/user-attachments/assets/dc5fd6e3-eaad-43c4-9f56-0eb8644789ae\">\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"87af12d21def2ff03e47d0df59b28dfa11436fa8"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201786","number":201786,"mergeCommit":{"message":"fix: [Search:AppSearch:Engines:Schema page]Add a new field modal dialog missing title from announcement (#201786)\n\nCloses: #201338\r\n\r\n## Description\r\nDialog modal visible title should be announced for the users, especially\r\nusing assistive technology to know what dialog modal, flyout opened.\r\n\r\n## What was changed?:\r\n\r\n1. aria-labelledby={modalTitleId} attribute was added for mentioned\r\nEuiModal\r\n\r\n# Screen\r\n<img width=\"1330\" alt=\"Screenshot 2024-11-26 at 15 40 20\"\r\nsrc=\"https://github.com/user-attachments/assets/dc5fd6e3-eaad-43c4-9f56-0eb8644789ae\">\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"87af12d21def2ff03e47d0df59b28dfa11436fa8"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this issue
Dec 12, 2024
…og missing title from announcement (elastic#201786) Closes: elastic#201338 ## Description Dialog modal visible title should be announced for the users, especially using assistive technology to know what dialog modal, flyout opened. ## What was changed?: 1. aria-labelledby={modalTitleId} attribute was added for mentioned EuiModal # Screen <img width="1330" alt="Screenshot 2024-11-26 at 15 40 20" src="https://github.com/user-attachments/assets/dc5fd6e3-eaad-43c4-9f56-0eb8644789ae"> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Dialog modal visible title should be announced for the users, especially using assistive technology to know what dialog modal opened.
Preconditions
Stateful App Search -> Engines -> Schema page is opened.
Engine is added.
Use Screen Reader (NVDA).
Steps to reproduce
1.Using only keyboard navigate to Create a schema field button by pressing Tab key.
2.Press Enter.
3.Observe screen reader.
UI elements + NVDA Speech Viewer
Actual Result
Expected Result
Meta Issue
Kibana Version: 8.17.0-SNAPSHOT
OS: Windows 11 Pro
Browser: Chrome Version 130.0.6723.70 (Official Build) (64-bit)
Screen reader: NVDA
WCAG or Vendor Guidance (optional)
Related to: https://github.com/elastic/search-team/issues/8256
The text was updated successfully, but these errors were encountered: