Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECO][Inventory V2] Turn off entityCentricExperience feature flag by default #204238

Closed
roshan-elastic opened this issue Dec 13, 2024 · 1 comment · Fixed by #204278
Closed

[ECO][Inventory V2] Turn off entityCentricExperience feature flag by default #204238

roshan-elastic opened this issue Dec 13, 2024 · 1 comment · Fixed by #204278
Assignees
Labels
Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team

Comments

@roshan-elastic
Copy link

We need to turn this off by default for all users now.

@botelastic botelastic bot added the needs-team Issues missing a team label label Dec 13, 2024
@wayneseymour wayneseymour added the Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team label Dec 13, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Dec 13, 2024
@jennypavlova jennypavlova self-assigned this Dec 13, 2024
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Dec 17, 2024
…default (elastic#204278)

Closes elastic#204238

## Summary

This PR turns off the`entityCentricExperience` feature flag by default

| Before | After |
| ------ | ------ |
| <img width="1917" alt="image"
src="https://github.com/user-attachments/assets/dbbe5b84-e16a-4578-8e67-1b3c31406da0"
/>|
![image](https://github.com/user-attachments/assets/20906756-3209-4b16-a44b-eacba6180874)|
|
![image](https://github.com/user-attachments/assets/37e1b6bc-1395-4f32-8e5b-1ddf4afd93b6)|
<img width="343" alt="image"
src="https://github.com/user-attachments/assets/66042e33-2cc9-4aa0-a9c7-e6a441141c08"
/> |
|
![image](https://github.com/user-attachments/assets/16b78af2-f9fc-4263-87cd-9dfa978410da)|
<img width="259" alt="image"
src="https://github.com/user-attachments/assets/37f54dd4-a969-4882-ab41-d94381bc1b23"
/> |
|
![image](https://github.com/user-attachments/assets/90d1b791-8f7f-40c2-a73b-3263cfc17a7f)
|
![image](https://github.com/user-attachments/assets/fd0417b0-5257-4bca-993f-51c08be47c14)|

## Testing
The `entityCentricExperience` feature flag should be turned off by
default and the inventory menu item should not be visible. The inventory
menu item should be visible if the flag is manually turned on.

https://github.com/user-attachments/assets/7bee8ccb-bb29-451e-8a64-22325d9d8477

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Sergi Romeu <sergi.romeu@elastic.co>
(cherry picked from commit 62c99f7)
kibanamachine added a commit that referenced this issue Dec 18, 2024
…ag by default (#204278) (#204648)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ECO][Inventory V2] Turn off entityCentricExperience feature flag by
default (#204278)](#204278)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"jennypavlova","email":"dzheni.pavlova@elastic.co"},"sourceCommit":{"committedDate":"2024-12-17T19:09:37Z","message":"[ECO][Inventory
V2] Turn off entityCentricExperience feature flag by default
(#204278)\n\nCloses #204238 \r\n\r\n## Summary\r\n\r\nThis PR turns off
the`entityCentricExperience` feature flag by default \r\n\r\n| Before |
After |\r\n| ------ | ------ |\r\n| <img width=\"1917\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/dbbe5b84-e16a-4578-8e67-1b3c31406da0\"\r\n/>|\r\n![image](https://github.com/user-attachments/assets/20906756-3209-4b16-a44b-eacba6180874)|\r\n|\r\n![image](https://github.com/user-attachments/assets/37e1b6bc-1395-4f32-8e5b-1ddf4afd93b6)|\r\n<img
width=\"343\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/66042e33-2cc9-4aa0-a9c7-e6a441141c08\"\r\n/>
|\r\n|\r\n![image](https://github.com/user-attachments/assets/16b78af2-f9fc-4263-87cd-9dfa978410da)|\r\n<img
width=\"259\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/37f54dd4-a969-4882-ab41-d94381bc1b23\"\r\n/>
|\r\n|\r\n![image](https://github.com/user-attachments/assets/90d1b791-8f7f-40c2-a73b-3263cfc17a7f)\r\n|\r\n![image](https://github.com/user-attachments/assets/fd0417b0-5257-4bca-993f-51c08be47c14)|\r\n\r\n##
Testing\r\nThe `entityCentricExperience` feature flag should be turned
off by\r\ndefault and the inventory menu item should not be visible. The
inventory\r\nmenu item should be visible if the flag is manually turned
on.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/7bee8ccb-bb29-451e-8a64-22325d9d8477\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
Sergi Romeu
<sergi.romeu@elastic.co>","sha":"62c99f73fdbf2649b75baf4d1fa3092850068c36","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","Team:obs-ux-management","v8.18.0"],"title":"[ECO][Inventory
V2] Turn off entityCentricExperience feature flag by
default","number":204278,"url":"https://github.com/elastic/kibana/pull/204278","mergeCommit":{"message":"[ECO][Inventory
V2] Turn off entityCentricExperience feature flag by default
(#204278)\n\nCloses #204238 \r\n\r\n## Summary\r\n\r\nThis PR turns off
the`entityCentricExperience` feature flag by default \r\n\r\n| Before |
After |\r\n| ------ | ------ |\r\n| <img width=\"1917\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/dbbe5b84-e16a-4578-8e67-1b3c31406da0\"\r\n/>|\r\n![image](https://github.com/user-attachments/assets/20906756-3209-4b16-a44b-eacba6180874)|\r\n|\r\n![image](https://github.com/user-attachments/assets/37e1b6bc-1395-4f32-8e5b-1ddf4afd93b6)|\r\n<img
width=\"343\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/66042e33-2cc9-4aa0-a9c7-e6a441141c08\"\r\n/>
|\r\n|\r\n![image](https://github.com/user-attachments/assets/16b78af2-f9fc-4263-87cd-9dfa978410da)|\r\n<img
width=\"259\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/37f54dd4-a969-4882-ab41-d94381bc1b23\"\r\n/>
|\r\n|\r\n![image](https://github.com/user-attachments/assets/90d1b791-8f7f-40c2-a73b-3263cfc17a7f)\r\n|\r\n![image](https://github.com/user-attachments/assets/fd0417b0-5257-4bca-993f-51c08be47c14)|\r\n\r\n##
Testing\r\nThe `entityCentricExperience` feature flag should be turned
off by\r\ndefault and the inventory menu item should not be visible. The
inventory\r\nmenu item should be visible if the flag is manually turned
on.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/7bee8ccb-bb29-451e-8a64-22325d9d8477\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
Sergi Romeu
<sergi.romeu@elastic.co>","sha":"62c99f73fdbf2649b75baf4d1fa3092850068c36"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204278","number":204278,"mergeCommit":{"message":"[ECO][Inventory
V2] Turn off entityCentricExperience feature flag by default
(#204278)\n\nCloses #204238 \r\n\r\n## Summary\r\n\r\nThis PR turns off
the`entityCentricExperience` feature flag by default \r\n\r\n| Before |
After |\r\n| ------ | ------ |\r\n| <img width=\"1917\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/dbbe5b84-e16a-4578-8e67-1b3c31406da0\"\r\n/>|\r\n![image](https://github.com/user-attachments/assets/20906756-3209-4b16-a44b-eacba6180874)|\r\n|\r\n![image](https://github.com/user-attachments/assets/37e1b6bc-1395-4f32-8e5b-1ddf4afd93b6)|\r\n<img
width=\"343\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/66042e33-2cc9-4aa0-a9c7-e6a441141c08\"\r\n/>
|\r\n|\r\n![image](https://github.com/user-attachments/assets/16b78af2-f9fc-4263-87cd-9dfa978410da)|\r\n<img
width=\"259\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/37f54dd4-a969-4882-ab41-d94381bc1b23\"\r\n/>
|\r\n|\r\n![image](https://github.com/user-attachments/assets/90d1b791-8f7f-40c2-a73b-3263cfc17a7f)\r\n|\r\n![image](https://github.com/user-attachments/assets/fd0417b0-5257-4bca-993f-51c08be47c14)|\r\n\r\n##
Testing\r\nThe `entityCentricExperience` feature flag should be turned
off by\r\ndefault and the inventory menu item should not be visible. The
inventory\r\nmenu item should be visible if the flag is manually turned
on.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/7bee8ccb-bb29-451e-8a64-22325d9d8477\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
Sergi Romeu
<sergi.romeu@elastic.co>","sha":"62c99f73fdbf2649b75baf4d1fa3092850068c36"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: jennypavlova <dzheni.pavlova@elastic.co>
Co-authored-by: Sergi Romeu <sergi.romeu@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants