Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] UX improvement: Clearing query input #20465

Closed
makwarth opened this issue Jul 4, 2018 · 3 comments
Closed

[APM] UX improvement: Clearing query input #20465

makwarth opened this issue Jul 4, 2018 · 3 comments
Assignees
@formgeist
Labels
Team:APM All issues that need APM UI Team support v6.4.0

Comments

@makwarth
Copy link

makwarth commented Jul 4, 2018 •
edited by formgeist
Loading

It's currently a bit clunky / confusing to clear the query input. As in after filtering you want to reset to no filtering.

We've previously discussed having an "x" icon on the right hand side of the input field to do this. (Or maybe there's an EUI way to do it)
@makwarth makwarth added Team:APM All issues that need APM UI Team support v6.4.0 labels Jul 4, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui

@formgeist
Copy link
Contributor

So EuiFieldSearch provides a clear input on hover and focus states, so I assume we can adopt this component. Not sure what happens with styling, but I think we ought to keep the current style to make it apparent that it's related to the Discover input. What's possible, @sqren?

image

@formgeist
Copy link
Contributor

This is fixed in #19469

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@formgeist formgeist

Labels
Team:APM All issues that need APM UI Team support v6.4.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@makwarth @formgeist @elasticmachine @alvarolobato