[APM] Add kuery to apm ui #19469
Merged
[APM] Add kuery to apm ui #19469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorenlouv
force-pushed
the
add-kuery-to-apm-ui
branch
2 times, most recently
from
b928b0d to
53c66c8
Compare
|
Pinging @elastic/apm-ui |
💚 Build Succeeded |
sorenlouv
force-pushed
the
add-kuery-to-apm-ui
branch
from
53c66c8 to
23b8631
Compare
💔 Build Failed |
💚 Build Succeeded |
sorenlouv
force-pushed
the
add-kuery-to-apm-ui
branch
from
a393da9 to
e529183
Compare
💚 Build Succeeded |
|
@sqren Added another todo; to add a search submit button like on Discover |
💚 Build Succeeded |
sorenlouv
force-pushed
the
add-kuery-to-apm-ui
branch
from
938a99a to
e1d6664
Compare
💔 Build Failed |
sorenlouv
force-pushed
the
add-kuery-to-apm-ui
branch
from
e1d6664 to
94d9376
Compare
💔 Build Failed |
💔 Build Failed |
sorenlouv
force-pushed
the
add-kuery-to-apm-ui
branch
from
e24d6da to
789d6cb
Compare
💚 Build Succeeded |
💚 Build Succeeded |
💚 Build Succeeded |
|
Since localtesting master is still broken for me, I've been testing it on the Cloud version you have running. I think it looks great. There's a few minor style tweaks we can make to the positioning and margins around the input. One thing that stuck with me was that there's no immediate way to clear the input entered. There's a solution available in the Eui forms, but obv that's not available here, but perhaps we can mimic the functionality. Basically, if there's text input in the field have a clear option on the far right with a clear icon both when your cursor is active in the input field, but also when hovering on the input if it's not active. Would that be reasonable to get in this version too, or what do you think @sqren? |
|
@formgeist I think the EUI component just uses the standard |
sorenlouv
force-pushed
the
add-kuery-to-apm-ui
branch
from
d152c04 to
3f0e2bc
Compare
💔 Build Failed |
|
retest |
💔 Build Failed |
💚 Build Succeeded |
💚 Build Succeeded |
💔 Build Failed |
💚 Build Succeeded |
💚 Build Succeeded |
sorenlouv
added a commit
to sorenlouv/kibana
that referenced
this pull request
Jul 11, 2018
* Add Kuery to APM UI * Format bool queries * Fix test * Add min-height * Updated css to vars * Added loading indicators * Update breadcrumbs * Update Discover links * Add search button * Fix readcrumb test * Remove debounce * Fix “undefined” kuery * Handle missing index pattern * Fix race condition in data fetching * Fix legacy url encoding * Filter out field-suggestions starting with "span*" * Convert KuiTable to EuiTable for service overview * Convert KuiTable to EuiTable for transaction overview * Convert KuiTable to EuiTable for error overview * Updated empty state messages * Bump CI jo * updated snapshots * Add beta tooltip and update to EuiSearch * Fixed issue with focus * Submit when clicking search button * Submit when clearing input * Handle missing index pattern * Remove query from spans # Conflicts: # yarn.lock
sorenlouv
added a commit
that referenced
this pull request
Jul 11, 2018
* Add Kuery to APM UI * Format bool queries * Fix test * Add min-height * Updated css to vars * Added loading indicators * Update breadcrumbs * Update Discover links * Add search button * Fix readcrumb test * Remove debounce * Fix “undefined” kuery * Handle missing index pattern * Fix race condition in data fetching * Fix legacy url encoding * Filter out field-suggestions starting with "span*" * Convert KuiTable to EuiTable for service overview * Convert KuiTable to EuiTable for transaction overview * Convert KuiTable to EuiTable for error overview * Updated empty state messages * Bump CI jo * updated snapshots * Add beta tooltip and update to EuiSearch * Fixed issue with focus * Submit when clicking search button * Submit when clearing input * Handle missing index pattern * Remove query from spans # Conflicts: # yarn.lock
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
undefinedshows up in the kuery barAdd saved searches functionality