Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chromium print reports seem to be rendering before the visualisations are complete #22581

Closed
chrisdavies opened this issue Aug 31, 2018 · 4 comments
Closed

Chromium print reports seem to be rendering before the visualisations are complete #22581

chrisdavies opened this issue Aug 31, 2018 · 4 comments
Assignees
@chrisdavies
Labels
(Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.0.0

Comments

@chrisdavies
Copy link
Contributor

The first visualization is blank (sometimes), and the rest are correct. This leads me to believe that Chromium is beginning the report rendering process too early. By the time the first visualization has been captured, the rest have rendered, so they are correctly captured.

Here's an example screenshot:

image
@chrisdavies chrisdavies added :Sharing v7.0.0 (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead v6.5.0 labels Aug 31, 2018
@chrisdavies chrisdavies self-assigned this Aug 31, 2018
chrisdavies added a commit to chrisdavies/kibana that referenced this issue Aug 31, 2018
@chrisdavies
Disable Chromium tests per elastic#22581
afac1d2
chrisdavies added a commit to chrisdavies/kibana that referenced this issue Aug 31, 2018
@chrisdavies
Fix elastic#22581 Chromium reports rendering a blank initial visualiz…
cd56981 
…ation
chrisdavies added a commit to chrisdavies/kibana that referenced this issue Aug 31, 2018
@chrisdavies
Attempt to fix elastic#22581 by introducing a delay to the
5645aa1 
waitForRenderComplete function in reporting
@chrisdavies chrisdavies mentioned this issue Sep 4, 2018
Closed
chrisdavies added a commit to chrisdavies/kibana that referenced this issue Sep 5, 2018
@chrisdavies
Fix elastic#22581 by introducing an artificial delay (elastic#22601)
2560015 
Introduce a delay into reports to allow visualizations time to appear in the DOM. This is intended as a temporary (and hacky) workaround until we come up with a more robust way to determine that all of the visualizations on the page are ready for capture.
@chrisdavies chrisdavies mentioned this issue Sep 5, 2018
Merged
chrisdavies added a commit that referenced this issue Sep 5, 2018
@chrisdavies
Fix #22581 by introducing an artificial delay (#22601) (#22716)
f04a760 
Introduce a delay into reports to allow visualizations time to appear in the DOM. This is intended as a temporary (and hacky) workaround until we come up with a more robust way to determine that all of the visualizations on the page are ready for capture.
@stacey-gammon stacey-gammon mentioned this issue Sep 12, 2018
Closed
@timroes timroes added Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure :Sharing labels Sep 13, 2018
@stacey-gammon
Copy link
Contributor

Hit here: #23507 (comment)

This we may need to extend the timeout.

@stacey-gammon stacey-gammon reopened this Oct 1, 2018
@stacey-gammon stacey-gammon mentioned this issue Oct 17, 2018
Closed
@rayafratkina
Copy link
Contributor

@stacey-gammon are we still planning to fix this for 6.5?

@stacey-gammon
Copy link
Contributor

We "fixed" it in a hacky way, but it still needs to be fixed legit style at some point.

@chrisdavies
Copy link
Contributor Author

Closing, as it's "fixed" for now. We can re-address it in the future if it surfaces again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisdavies chrisdavies

Labels
(Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.0.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@chrisdavies @timroes @stacey-gammon @rayafratkina