Routing: Handle search params already in the URL #23046
Assignees
Labels
loe:medium
Medium Level of Effort
PR sent
Team:Presentation
Presentation Team for Dashboard, Input Controls, and Canvas
Comments
|
Original comment by @w33ble:
This issue is about using the query data, LINK REDACTED was about the router not working when query data exists. |
kibanamachine
added
Team:Presentation
w33ble
added a commit
that referenced
this issue
Nov 19, 2018
Closes #23046 Switch to a hash history manager that supports pushState and replaceState. This makes the "basepath" part of the hash's concern, so anything before the hash no longer matters. This also allows undoing a bunch of hacky fixes. This also allows the `urlparam` function to work again! ヽ(；▽；)ノ 
w33ble
added a commit
that referenced
this issue
Nov 19, 2018
Closes #23046 Switch to a hash history manager that supports pushState and replaceState. This makes the "basepath" part of the hash's concern, so anything before the hash no longer matters. This also allows undoing a bunch of hacky fixes. This also allows the `urlparam` function to work again! ヽ(；▽；)ノ 
w33ble
added a commit
that referenced
this issue
Nov 19, 2018
Closes #23046 Switch to a hash history manager that supports pushState and replaceState. This makes the "basepath" part of the hash's concern, so anything before the hash no longer matters. This also allows undoing a bunch of hacky fixes. This also allows the `urlparam` function to work again! ヽ(；▽；)ノ 
w33ble
added a commit
that referenced
this issue
Nov 21, 2018
~~Blocked by #23046 (pending #25828 merged Adds functional smoke tests for Canvas. - Loads and checks the list of workpads - Loads the first workpad and checks that elements render This is the simple workpad it's testing 
w33ble
added a commit
that referenced
this issue
Nov 21, 2018
~~Blocked by #23046 (pending #25828 merged Adds functional smoke tests for Canvas. - Loads and checks the list of workpads - Loads the first workpad and checks that elements render This is the simple workpad it's testing 
w33ble
added a commit
to w33ble/kibana
that referenced
this issue
Nov 21, 2018
~~Blocked by elastic#23046 (pending elastic#25828 merged Adds functional smoke tests for Canvas. - Loads and checks the list of workpads - Loads the first workpad and checks that elements render This is the simple workpad it's testing 
w33ble
added a commit
that referenced
this issue
Nov 21, 2018
~~Blocked by #23046 (pending #25828 merged Adds functional smoke tests for Canvas. - Loads and checks the list of workpads - Loads the first workpad and checks that elements render This is the simple workpad it's testing 
w33ble
added a commit
that referenced
this issue
Nov 22, 2018
* chore: revert #25921 / d76c0ae * Test: canvas functional smoke test (#25262) ~~Blocked by #23046 (pending #25828 merged Adds functional smoke tests for Canvas. - Loads and checks the list of workpads - Loads the first workpad and checks that elements render This is the simple workpad it's testing  * test: add ci group tags backport of #26046 * chore: shot in the dark beforeAll fix * chore: add some debug logging in the beforeAll hook, to see where it's getting stuck * [canvas/archive] remove _1 from .kibana archives to avoid lockup
w33ble
added a commit
that referenced
this issue
Nov 22, 2018
* Test: canvas functional smoke test (#25262) ~~Blocked by #23046 (pending #25828 merged Adds functional smoke tests for Canvas. - Loads and checks the list of workpads - Loads the first workpad and checks that elements render This is the simple workpad it's testing  * [canvas/archive] remove _1 from .kibana archives to avoid lockup (cherry picked from commit d51e554)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Original comment by @w33ble:
This is a requirement for the upcoming the
forceNowparameter. See this comment in the PR.Reporting will be setting a query parameter on the URL, which the underlying application will need to know how to handle. This means our router's
basenamewill change, which will break the router. On startup, we'll need to grab any search values off the route and stash them somewhere, either by re-writing it to hash or putting it into state or something.The text was updated successfully, but these errors were encountered: