-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues with new Listing component #31599
Comments
Pinging @elastic/kibana-app |
Both issues are fixed in the PR. Since the button is still a button (EUI table doesn't support having actions with links), I had to pass in two functions from the Angular code (one is a click handler and the other returns the URL). Also, EUI InMemoryTable supports loading in unordered state, but once the user sorted once, he can't go back to an unsorted state. This is accepted behavior according to @timroes I have opened an EUI issue for this. |
@lizozom I think we either need to give the EUI team some support on implementing that, or at lest should check where that could fit on their roadmap, since we need it do be done (and fixed our stuff) by 7.1, to not cause the sorting issue to cause a regression. |
@lizozom Since on visualization the edit button and the link itself do exactly the same thing I was wondering if we might just want to pass |
Hey @timroes I think it's good to have it for the sake of UI consistency.. |
* Fixing bugs from #31599 * Make listing item links instead of buttons * restore dashboard edit button behavior
* Fixing bugs from elastic#31599 * Make listing item links instead of buttons * restore dashboard edit button behavior
With #30610 a new listing component was introduced for visualization and dashboard listing. There are a few issues, we still need to fix before releasing:
a
) element to being abutton
with that PR. We should make sure that the link is actually a link for a couple of reasons: Better accessibility (navigation should be links, action should be buttons), with a button we prevent users from opening that page in a new tab.cc @lizozom @flash1293
The text was updated successfully, but these errors were encountered: