Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs UI] Custom panel font sizes don't follow their expected scales #32759

Closed
formgeist opened this issue Mar 8, 2019 · 1 comment · Fixed by #33411
Closed

[Logs UI] Custom panel font sizes don't follow their expected scales #32759

formgeist opened this issue Mar 8, 2019 · 1 comment · Fixed by #33411
Assignees
@weltenwort
Labels
bug Fixes for quality problems that affect the customer experience Feature:Logs UI Logs UI feature

Comments

@formgeist
Copy link
Contributor

Kibana version: 8.0.0

Elasticsearch version: 8.0.0

Description of the problem including expected versus actual behavior:

Just noticed this while testing out the UI. Seems like the font-size scales in the customize panel don't follow their expected sizing. Small is i.e. larger than medium.

kapture 2019-03-08 at 14 24 36
@formgeist formgeist added bug Fixes for quality problems that affect the customer experience Feature:Logs UI Logs UI feature labels Mar 8, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/infrastructure-ui

@weltenwort weltenwort mentioned this issue Mar 18, 2019
Merged
1 task
weltenwort added a commit that referenced this issue Mar 18, 2019
@weltenwort
[Logs UI] Fix font size references after EUI upstream change (#33411)
04f816b 
This fixes the `small` font scale of the log viewer to correctly reference the EUI font size again. Before this fix, the `small` font scale was rendered larger than `medium`. Similarly, the tick labels of the log minimap were being rendered too large.

Both resulted from a breaking change of the exported variable names in elastic/eui#1590.

fixes #32759
weltenwort added a commit to weltenwort/kibana that referenced this issue Mar 18, 2019
@weltenwort
[Logs UI] Fix font size references after EUI upstream change (elastic…
4c29cec 
…#33411)

This fixes the `small` font scale of the log viewer to correctly reference the EUI font size again. Before this fix, the `small` font scale was rendered larger than `medium`. Similarly, the tick labels of the log minimap were being rendered too large.

Both resulted from a breaking change of the exported variable names in elastic/eui#1590.

fixes elastic#32759
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weltenwort weltenwort

Labels
bug Fixes for quality problems that affect the customer experience Feature:Logs UI Logs UI feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Logs UI] Fix font size references after EUI upstream change weltenwort/kibana
5 participants
@ruflin @weltenwort @formgeist @elasticmachine @alvarolobato