-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core HTTP fetch service doesn't return AbortError #51406
Comments
Pinging @elastic/kibana-platform (Team:Platform) |
the problem seems to be solved in https://github.com/elastic/kibana/pull/53766/files/5ad68ea3f314aaec889c85805e4e77e9d0236fc6#diff-fc8d4853dbfb5a62d938e7155ee7d372 |
Fixed by #53766. |
requires at least minimal test coverage |
Marking as chore since this is just writing tests now |
Please keep this in mind when creating tests: #56244 |
When aborting a request using the core HTTP
fetch
, the error it returns has a genericname
of'Error'
, rather than anAbortError
(see https://developer.mozilla.org/en-US/docs/Web/API/AbortSignal).I understand we're using our own
fetch
service but it would be nice if we had a specific, possibly typed, error that we can use to know in the handler whether the request was aborted or if the error was some other kind of error. At the very least it'd be nice if the error'sname
wasAbortError
, similar to how most browsers implementfetch
.Code example:
The text was updated successfully, but these errors were encountered: