Clean up search service #53766

lizozom · 2019-12-23T14:06:19Z

Summary

Partially resolves #46934.

As #44302 won't allow us to switch over to the new service, this PR contains all the changes necessary to make the switch, but without actually making it.

New search service & further improvements

This PR contains tested infrastructure for the new data.searchService.

Replace the angular es service in default_search_strategy.ts with a non-angular one and removes any angular \ old platform dependencies from search source and default search strategy, to allow moving them to NP.
LoadingIndicator handling - show loading indicator while searching
Exposing error codes and info from the search route
Changing the way getPainlessError is processed due to slightly different response from new endpoint.
Allow AbortError to be thrown directly from http service @elastic/kibana-platform for your review
Triggering a digest cycle in maps, as its now not being triggered automatically by elasticsearch client.
Minor fix for test/functional/apps/discover/_errors.js that allows running it independently

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

elasticmachine · 2019-12-23T14:06:22Z

Pinging @elastic/kibana-app-arch (Team:AppArch)

kibanamachine · 2019-12-23T15:19:08Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 115fa6b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine · 2019-12-23T17:48:34Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 81ef64d

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine · 2019-12-24T18:45:52Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 8e999d1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…search-msearch

kibanamachine · 2020-01-02T10:47:22Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: fc9c714

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine · 2020-01-02T14:33:02Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 726e9e3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…search-msearch

…kibana into newplatform/data/search-msearch

…search-msearch

lukasolson · 2020-01-16T21:35:11Z

src/plugins/data/public/search/es_client/get_es_client.ts

+    const customPromiseThingy = esClient[method](args);
+    const { abort } = customPromiseThingy;


This one is @spalger approved 🤣

lukasolson · 2020-01-16T21:36:40Z

src/plugins/data/public/search/search_service.ts

@@ -51,6 +53,9 @@ declare module 'kibana/public' {

 export interface ISearchStart {
  search: ISearchGeneric;
+  __LEGACY: {
+    esClient: any;


Does this need to be any? I think we have a type for this (APICaller).

I have a follow up PR doing that https://github.com/elastic/kibana/pull/54337/files#diff-c55654fe5ffdab0adcd2c5bda2f863e0R52

lizozom · 2020-01-17T22:52:54Z

@elasticmachine merge upstream

…search-msearch

lizozom · 2020-01-20T10:34:34Z

@elasticmachine merge upstream

…search-msearch

…kibana into newplatform/data/search-msearch

kibanamachine · 2020-01-21T13:41:08Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: faddcd3

History

💚 Build #21347 succeeded 2677b3b
💚 Build #21291 succeeded 7ac79fd
💚 Build #21213 succeeded 487c64e
💚 Build #20822 succeeded 0e8c21c
💔 Build #20802 failed 6b80ecf

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* deprecate msearch * Missing export * adjust tests, revert loading method of esaggs/boot * getInjectedMetadata * Fix jest tests * update default strategy abort test * notice update * Allow running discover errors test independently * Remove batchSearches * Detect painless script error * don't show notifications for aborted requests * Fix jest tests * Restore loader indicator * Decreace loading count on error * update search test * Trigger digest after fetching fresh index patterns * Revert isEqual * accurate revert * Return full error details to client from search endpoint * Re-throw AbortError from http when user aborts request. * fix typo * typo * Adjust routes jest test * Restore msearch using a separate es connection * typescript fixes * set http service mock * Move es client to dat aplugin, for follow up PR * Add karma mock * krma mock * fix tests * ts * Pass in version dynamically * add headers to esClient host * Restored fetch soon test Use tap for loadingCount side effects * Cleanup search params * Cleanup search params test * Revert "Cleanup search params" This reverts commit ca9dea0. * Revert "Cleanup search params test" This reverts commit 30b9478. * Revert code to use old es client until elastic#44302 is resolved * Revert changes to getPainlessError * Fix jest test * Refactor esClient to trigger loadingIndicator * fixing tests * use esClient from searchService * git remove comment * fix jest Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* deprecate msearch * Missing export * adjust tests, revert loading method of esaggs/boot * getInjectedMetadata * Fix jest tests * update default strategy abort test * notice update * Allow running discover errors test independently * Remove batchSearches * Detect painless script error * don't show notifications for aborted requests * Fix jest tests * Restore loader indicator * Decreace loading count on error * update search test * Trigger digest after fetching fresh index patterns * Revert isEqual * accurate revert * Return full error details to client from search endpoint * Re-throw AbortError from http when user aborts request. * fix typo * typo * Adjust routes jest test * Restore msearch using a separate es connection * typescript fixes * set http service mock * Move es client to dat aplugin, for follow up PR * Add karma mock * krma mock * fix tests * ts * Pass in version dynamically * add headers to esClient host * Restored fetch soon test Use tap for loadingCount side effects * Cleanup search params * Cleanup search params test * Revert "Cleanup search params" This reverts commit ca9dea0. * Revert "Cleanup search params test" This reverts commit 30b9478. * Revert code to use old es client until #44302 is resolved * Revert changes to getPainlessError * Fix jest test * Refactor esClient to trigger loadingIndicator * fixing tests * use esClient from searchService * git remove comment * fix jest Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

deprecate msearch

115fa6b

lizozom added v8.0.0 Team:AppArch release_note:skip Skip the PR/issue when compiling release notes Feature:NP Migration v7.6.0 labels Dec 23, 2019

lizozom self-assigned this Dec 23, 2019

Liza K added 3 commits December 23, 2019 15:54

Missing export

87ae717

adjust tests, revert loading method of esaggs/boot

0593782

getInjectedMetadata

81ef64d

Liza K added 2 commits December 24, 2019 16:53

Fix jest tests

0063499

update default strategy abort test

8e999d1

Liza K added 2 commits January 2, 2020 11:28

Merge remote-tracking branch 'upstream/master' into newplatform/data/…

fc9c714

…search-msearch

notice update

dfcb01b

Liza K added 3 commits January 2, 2020 13:43

Allow running discover errors test independently

2d8c3a3

Remove batchSearches

c665b75

Detect painless script error

726e9e3

Liza K added 6 commits January 2, 2020 19:06

don't show notifications for aborted requests

4eb0b8d

Merge remote-tracking branch 'upstream/master' into newplatform/data/…

6950144

…search-msearch

Fix jest tests

f2510bb

Restore loader indicator

d68de49

Decreace loading count on error

74fc277

update search test

27e95df

Liza K added 6 commits January 15, 2020 19:14

Merge branch 'newplatform/data/search-msearch' of github.com:lizozom/…

9ad7561

…kibana into newplatform/data/search-msearch

fixing tests

aa0506a

Merge remote-tracking branch 'upstream/master' into newplatform/data/…

45f5f78

…search-msearch

use esClient from searchService

2ade3a6

git remove comment

6b80ecf

fix jest

0e8c21c

lukasolson reviewed Jan 16, 2020

View reviewed changes

This was referenced Jan 16, 2020

[Search] Remove legacy ES client #55139

Closed

Remove courier:batchSearches setting and usage of _msearch APIs #55140

Closed

Merge remote-tracking branch 'upstream/master' into newplatform/data/…

487c64e

…search-msearch

lizozom added v7.7.0 and removed v7.6.0 labels Jan 17, 2020

elastic deleted a comment from elasticmachine Jan 18, 2020

Merge remote-tracking branch 'upstream/master' into newplatform/data/…

7ac79fd

…search-msearch

lizozom requested a review from lukasolson January 20, 2020 10:34

elasticmachine and others added 3 commits January 20, 2020 05:34

Merge branch 'master' into newplatform/data/search-msearch

2677b3b

Merge remote-tracking branch 'upstream/master' into newplatform/data/…

dd5d32d

…search-msearch

Merge branch 'newplatform/data/search-msearch' of github.com:lizozom/…

faddcd3

…kibana into newplatform/data/search-msearch

lizozom added the review label Jan 21, 2020

lukasolson approved these changes Jan 21, 2020

View reviewed changes

lizozom merged commit f265961 into elastic:master Jan 21, 2020

lizozom mentioned this pull request Jan 21, 2020

[7.x] Clean up search service (#53766) #55434

Merged

lukasolson mentioned this pull request Jan 21, 2020

Core HTTP fetch service doesn't return AbortError #51406

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clean up search service #53766

Clean up search service #53766

lizozom commented Dec 23, 2019 •

edited

Loading

elasticmachine commented Dec 23, 2019

kibanamachine commented Dec 23, 2019

kibanamachine commented Dec 23, 2019

kibanamachine commented Dec 24, 2019

kibanamachine commented Jan 2, 2020

kibanamachine commented Jan 2, 2020

lukasolson Jan 16, 2020

lizozom Jan 17, 2020 •

edited

Loading

lukasolson Jan 16, 2020

lizozom Jan 17, 2020

lizozom commented Jan 17, 2020

lizozom commented Jan 20, 2020

kibanamachine commented Jan 21, 2020

		const customPromiseThingy = esClient[method](args);
		const { abort } = customPromiseThingy;

Clean up search service #53766

Clean up search service #53766

Conversation

lizozom commented Dec 23, 2019 • edited Loading

Summary

New search service & further improvements

Checklist

For maintainers

elasticmachine commented Dec 23, 2019

kibanamachine commented Dec 23, 2019

💔 Build Failed

kibanamachine commented Dec 23, 2019

💔 Build Failed

kibanamachine commented Dec 24, 2019

💔 Build Failed

kibanamachine commented Jan 2, 2020

💔 Build Failed

kibanamachine commented Jan 2, 2020

💔 Build Failed

lukasolson Jan 16, 2020

Choose a reason for hiding this comment

lizozom Jan 17, 2020 • edited Loading

Choose a reason for hiding this comment

lukasolson Jan 16, 2020

Choose a reason for hiding this comment

lizozom Jan 17, 2020

Choose a reason for hiding this comment

lizozom commented Jan 17, 2020

lizozom commented Jan 20, 2020

kibanamachine commented Jan 21, 2020

💚 Build Succeeded

History

lizozom commented Dec 23, 2019 •

edited

Loading

lizozom Jan 17, 2020 •

edited

Loading