Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Keystore to New Platform #52107

Closed
1 task
tylersmalley opened this issue Dec 3, 2019 · 2 comments · Fixed by #83483
Closed
1 task

Migrate Keystore to New Platform #52107

tylersmalley opened this issue Dec 3, 2019 · 2 comments · Fixed by #83483
Assignees
Labels

Comments

@tylersmalley
Copy link
Contributor

tylersmalley commented Dec 3, 2019

The keystore settings either need exposed by a new plugin in the new platform, or added to core. Currently, these settings are being injected into the Hapi.

The libraries for this are located at https://github.com/elastic/kibana/tree/master/src/legacy/server/keystore

@joshdover do you have a preference for if this should be a new plugin or exposed vai core?

  • Remove utils/{question,prompt}
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@joshdover
Copy link
Contributor

This seems wrong, but the only usages I find are in CLI tools. I'm not familiar with what we use the keystore for in Kibana, are there plugins using this API?

If not, could we not move this to somewhere in src/cli or src/cli_keystore?

@tylersmalley tylersmalley added the Feature:Configuration Settings in kibana.yml label Feb 20, 2020
jbudz added a commit to jbudz/kibana that referenced this issue Nov 16, 2020
Currently keystore parsing is in the legacy http server folder.
Keystore references end in src/cli so instead of migrating to
core/server the I opted for the closest fit in the CLI folder.

Closes elastic#52107
jbudz added a commit that referenced this issue Nov 17, 2020
Currently keystore parsing is in the legacy http server folder.
Keystore references end in src/cli so instead of migrating to
core/server the I opted for the closest fit in the CLI folder.

Closes #52107
jbudz added a commit that referenced this issue Nov 17, 2020
Currently keystore parsing is in the legacy http server folder.
Keystore references end in src/cli so instead of migrating to
core/server the I opted for the closest fit in the CLI folder.

Closes #52107
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants