Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Platform Applications flashes "Application Not Found" UI when loading #56409

Closed
rudolf opened this issue Jan 30, 2020 · 4 comments · Fixed by #56483
Closed

Platform Applications flashes "Application Not Found" UI when loading #56409

rudolf opened this issue Jan 30, 2020 · 4 comments · Fixed by #56483
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@rudolf
Copy link
Contributor

rudolf commented Jan 30, 2020

When loading a valid enabled application, we briefly render the following "Application Not Found" error page:
Screen Shot 2020-01-30 at 12 14 36 PM

Seems to be caused by this line: https://github.com/elastic/kibana/blob/master/src/core/public/application/ui/app_container.tsx#L57

@rudolf rudolf added bug Fixes for quality problems that affect the customer experience Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform labels Jan 30, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@rudolf rudolf changed the title Platform Applications flashes "Not Found" UI when loading Platform Applications flashes "Application Not Found" UI when loading Jan 30, 2020
@pgayvallet
Copy link
Contributor

Related to #54656

@pgayvallet
Copy link
Contributor

@jasonrhodes I tried to reproduce, by both accessing an initial NP app using a refresh, or navigating from either a NP or LP app to a NP one, and I can't see the flickering on my machine.

Is there a reproduction scenario for this?

@pgayvallet
Copy link
Contributor

Confirmed. The first render is done before the status observable hook is initialized

const appStatuses = useObservable(appStatuses$, new Map());

Causing an initial not found display until the first render is done:

unmountRef.current =
(await mounter.mount({
appBasePath: mounter.appBasePath,
element: elementRef.current!,
onAppLeave: handler => setAppLeaveHandler(appId, handler),
})) || null;
setAppNotFound(false);
};

Moving the setAppNotFound(false); before the await seems to be enough to address the issue.

However, the time we await the actual mount handler to resolve will still display a blank content. This is way less impacting that displaying the error message, but we might want to display the loader while awaiting the mount. This is outside of the scope of this issue though, and minor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants