Show error page when accessing unavailable app #54656

pgayvallet · 2020-01-13T21:34:28Z

Summary

Propagate the applications current states from the ApplicationService to the AppRouter to be able to display the notFound page when mounting an application that is not available.

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
~~- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support~~
~~- [ ] Documentation was added for features that require explanation or tutorials~~
Unit or functional tests were updated or added to match the most common scenarios
~~- [ ] This was checked for keyboard-only and screenreader accessibility~~

For maintainers

~~- [ ] This was checked for breaking API changes and was labeled appropriately~~
~~- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately~~

…navailable app

…able-app-not-found

pgayvallet · 2020-01-15T13:48:26Z

src/core/public/application/application_service.test.ts

-      expect(getComponent()).toMatchInlineSnapshot(`
-        <AppRouter
-          history={
-            Object {
-              "push": [MockFunction],
-            }
-          }
-          mounters={Map {}}
-          setAppLeaveHandler={[Function]}
-        />
-      `);
+      expect(getComponent()).toMatchSnapshot();


The AppRouter now have an observable as a property. This causes the snapshot to be incredibly long, as all inner properties of the observer are rendered. I would love to be able to exclude some properties from the snapshot, but that doesn't seem doable, so I moved from inline to file snapshot.

pgayvallet · 2020-01-15T14:03:18Z

test/plugin_functional/plugins/core_app_status/public/plugin.tsx

+    window.__coreAppStatus = startContract;
+    return startContract;


I need to be able to test NP to NP app navigation. As we are not loading LP plugins in non-legacy mode, I can't use the core_provider_plugin plugin anymore and I'm forced to expose my own API to the global scope.

You could add buttons to click on instead, but this is probably less flaky.

for navigateToApp I could (even if for core FT I think I prefer using directly our APIs), but not for the setAppStatus I'm also using

elasticmachine · 2020-01-15T14:16:04Z

Pinging @elastic/kibana-platform (Team:Platform)

…able-app-not-found

joshdover · 2020-01-16T23:11:03Z

test/plugin_functional/test_suites/core_plugins/application_status.ts

      cb();
    }, s);
  };

-  const navigateToApp = async (i: string): Promise<{ error?: string }> => {
+  const navigateToApp = async (i: string) => {
    return (await browser.executeAsync(async (appId, cb: Function) => {


unnecessary await?

joshdover · 2020-01-17T15:29:22Z

test/plugin_functional/plugins/core_app_status/public/plugin.tsx

+    window.__coreAppStatus = startContract;
+    return startContract;


You could add buttons to click on instead, but this is probably less flaky.

…able-app-not-found

kibanamachine · 2020-01-20T13:59:11Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 5b75c9e

History

💚 Build #21318 succeeded ea1d0d4
💚 Build #21019 succeeded 6099850
💚 Build #20578 succeeded 7da23d7
💚 Build #20557 succeeded d6eccf7
💚 Build #20547 succeeded 1a8035e

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* display not found page instead of throwing an error when accessible unavailable app * move types to public folder * fix types import * remove updater from start app * remove unnecessary await

* upstream/master: (24 commits) Show error page when accessing unavailable app (elastic#54656) [ML] Improving job wizards with datafeed aggregations (elastic#55180) remove flaly assetion. a license presence tested anyway (elastic#55289) fix commonly used ranges uptime (elastic#54930) [SIEM] Use proper icons on Detections view (elastic#55215) Fix: invalid translation referenced (elastic#54901) [State Management] Remove AppState from edit_index_pattern page (elastic#54104) Implements `getStartServices` on server-side (elastic#55156) Move vis_vega_type/data_model tests to jest (elastic#55186) [SIEM] [Detection Engine] Update status on rule details page (elastic#55201) Fix KQL value suggestions for nested fields (elastic#54820) Enforce camelCase format for a plugin id (elastic#53759) [SIEM] Detection engine cleanup for rule details/creation/edit page (elastic#55069) Remove nested root from index pattern (elastic#54978) [Reporting/Migration] ReportingSetup, LegacySetup (elastic#54198) [SIEM] [Detection Engine] Fixes duplicate rule action (elastic#55252) [SIEM] Detections add alert & signal tab (elastic#55127) Management API - redirect on disabled app path (elastic#55136) [SIEM][Detection Engine] Fixes critical regression on the backend with immutable and tags update local (elastic#55177) ...

* master: (108 commits) [ML] Single Metric Viewer: Fix job check. (elastic#55191) Show error page when accessing unavailable app (elastic#54656) [ML] Improving job wizards with datafeed aggregations (elastic#55180) remove flaly assetion. a license presence tested anyway (elastic#55289) fix commonly used ranges uptime (elastic#54930) [SIEM] Use proper icons on Detections view (elastic#55215) Fix: invalid translation referenced (elastic#54901) [State Management] Remove AppState from edit_index_pattern page (elastic#54104) Implements `getStartServices` on server-side (elastic#55156) Move vis_vega_type/data_model tests to jest (elastic#55186) [SIEM] [Detection Engine] Update status on rule details page (elastic#55201) Fix KQL value suggestions for nested fields (elastic#54820) Enforce camelCase format for a plugin id (elastic#53759) [SIEM] Detection engine cleanup for rule details/creation/edit page (elastic#55069) Remove nested root from index pattern (elastic#54978) [Reporting/Migration] ReportingSetup, LegacySetup (elastic#54198) [SIEM] [Detection Engine] Fixes duplicate rule action (elastic#55252) [SIEM] Detections add alert & signal tab (elastic#55127) Management API - redirect on disabled app path (elastic#55136) [SIEM][Detection Engine] Fixes critical regression on the backend with immutable and tags ...

* display not found page instead of throwing an error when accessible unavailable app * move types to public folder * fix types import * remove updater from start app * remove unnecessary await

pgayvallet added 5 commits January 13, 2020 22:33

display not found page instead of throwing an error when accessible u…

d80362c

…navailable app

move types to public folder

cadefa8

fix types import

e7fd395

Merge remote-tracking branch 'upstream/master' into kbn-54366-unavail…

1a8035e

…able-app-not-found

remove updater from start app

d6eccf7

pgayvallet commented Jan 15, 2020

View reviewed changes

pgayvallet added Feature:New Platform release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.7.0 v8.0.0 labels Jan 15, 2020

pgayvallet marked this pull request as ready for review January 15, 2020 14:16

pgayvallet requested a review from a team as a code owner January 15, 2020 14:16

pgayvallet added 2 commits January 15, 2020 16:31

Merge remote-tracking branch 'upstream/master' into kbn-54366-unavail…

7da23d7

…able-app-not-found

Merge remote-tracking branch 'upstream/master' into kbn-54366-unavail…

6099850

…able-app-not-found

joshdover reviewed Jan 17, 2020

View reviewed changes

joshdover approved these changes Jan 17, 2020

View reviewed changes

pgayvallet added 3 commits January 20, 2020 08:20

Merge remote-tracking branch 'upstream/master' into kbn-54366-unavail…

beb00e1

…able-app-not-found

remove unnecessary await

ea1d0d4

Merge remote-tracking branch 'upstream/master' into kbn-54366-unavail…

5b75c9e

…able-app-not-found

pgayvallet merged commit de7a22d into elastic:master Jan 20, 2020

pgayvallet mentioned this pull request Jan 20, 2020

[7.x] Show error page when accessing unavailable app (#54656) #55317

Merged

This was referenced Jan 30, 2020

[BUG] Loading a plugin from plugins directory flickers #56362

Closed

Platform Applications flashes "Application Not Found" UI when loading #56409

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Show error page when accessing unavailable app #54656

Show error page when accessing unavailable app #54656

pgayvallet commented Jan 13, 2020 •

edited

Loading

pgayvallet Jan 15, 2020

pgayvallet Jan 15, 2020

joshdover Jan 17, 2020

pgayvallet Jan 17, 2020

elasticmachine commented Jan 15, 2020

joshdover Jan 16, 2020

joshdover Jan 17, 2020

kibanamachine commented Jan 20, 2020

		window.__coreAppStatus = startContract;
		return startContract;

Show error page when accessing unavailable app #54656

Show error page when accessing unavailable app #54656

Conversation

pgayvallet commented Jan 13, 2020 • edited Loading

Summary

Checklist

For maintainers

pgayvallet Jan 15, 2020

Choose a reason for hiding this comment

pgayvallet Jan 15, 2020

Choose a reason for hiding this comment

joshdover Jan 17, 2020

Choose a reason for hiding this comment

pgayvallet Jan 17, 2020

Choose a reason for hiding this comment

elasticmachine commented Jan 15, 2020

joshdover Jan 16, 2020

Choose a reason for hiding this comment

joshdover Jan 17, 2020

Choose a reason for hiding this comment

kibanamachine commented Jan 20, 2020

💚 Build Succeeded

History

pgayvallet commented Jan 13, 2020 •

edited

Loading