Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] Keep lines on Point to Point layers visible as user zooms in #59106

Closed
kindsun opened this issue Mar 3, 2020 · 7 comments
Closed

[Maps] Keep lines on Point to Point layers visible as user zooms in #59106

kindsun opened this issue Mar 3, 2020 · 7 comments
Labels
enhancement New value added to drive a business result Feature:Maps Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@kindsun
Copy link
Contributor

kindsun commented Mar 3, 2020

Describe the feature:

When filtering a Point to Point (pew pew) Layer by map bounds, either prevent filtering or allow a user to configure whether or not lines are filtered out.

I believe this was discussed when Point to Point layers was originally introduced, but I don't see it captured in writing anywhere. It's also possible that it was tabled pending a better solution for storing and retrieving lines on the ES side, which has been captured here. This solution would likely be a lot cleaner vs. creating the lines on-the-fly on the client side (as we do now) and excepting points from geo_bounding_box filters.

Also related: #31396

Describe a specific use case for the feature:

Any time a user wants to zoom in on a Map point feature connected by lines and wants that line to stay present for context. Also any time the lines themselves may be of primary interest and a user wants to zoom in on a cluster or intersection of them.

@kindsun kindsun added [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation enhancement New value added to drive a business result labels Mar 3, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@thomasneirynck
Copy link
Contributor

thomasneirynck commented Mar 3, 2020

Point2point needs to balance multiple conflicting requirements:

  • high precision zoomed in vs low prevision zoomed out
  • constraining the aggregation size using bounded query vs showing lines out-of-bounds for context

This ticket essentially asks for removing the bounds-filter from the request. This has the potential of vastly increasing the bucket-limit for high precision request (e.g. zoomed in).

Additional write-up here #46515 (comment)

Not sure what the "best" approach is here.

@kindsun
Copy link
Contributor Author

kindsun commented Mar 3, 2020

The solution might just be to wait for elastic/elasticsearch#41649, at which point the nature of point to point either changes to use geo_lines or gets deprecated in favor of that layer type

@nreese
Copy link
Contributor

nreese commented Mar 3, 2020

The solution might just be to wait for elastic/elasticsearch#41649, at which point the nature of point to point either changes to use geo_lines or gets deprecated in favor of that layer type

Not sure geoline will provide any help in this case. Geoline connects multiple documents into a line. Point2point connects aggregated source and destinations where source and destination come from a single document.

@kindsun
Copy link
Contributor Author

kindsun commented Mar 3, 2020

Not sure geoline will provide any help in this case. Geoline connects multiple documents into a line. Point2point connects aggregated source and destinations where source and destination come from a single document.

Unless there were a reindexing step? A user might be interested in pulling that data out into a separate index

@jb1b84 jb1b84 added Feature:Maps Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Nov 3, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@jb1b84 jb1b84 removed the [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation label Nov 3, 2022
@nreese
Copy link
Contributor

nreese commented Mar 9, 2023

@nreese nreese closed this as completed Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Maps Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

5 participants