Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rollups][ES-UI] No Error Message Shown for when Rollup Matches All Indices #63270

Closed
cuff-links opened this issue Apr 10, 2020 · 6 comments
Closed
Labels
bug Fixes for quality problems that affect the customer experience Feature:Rollups Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.7.1

Comments

@cuff-links
Copy link
Contributor

Environment:
OS: Windows and Mac
Browsers: All
Version: 7.7 BC5

Steps to Reproduce
1.) Create a new rollup
2.) Do not select any options for pages 3-5
3.) Review rollup and click save on the last page.

Expected Result
Rollup is created and you are navigated to the rollups page with the new rollup in the table.

Actual Result
Error:
Request failed with a 400 error. [x_content_parse_exception] Failed to build [xpack/rollup/jobconfig] after last required field arrived

No extra logging in the console.

Screenshot
Screen Shot 2020-04-10 at 2 43 06 PM

@cuff-links cuff-links added bug Fixes for quality problems that affect the customer experience Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Feature:Rollups v7.7.0 labels Apr 10, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@cjcenizal cjcenizal self-assigned this Apr 10, 2020
@cjcenizal
Copy link
Contributor

cjcenizal commented Apr 10, 2020

The error here is due to the index pattern capturing the rollup index. I haven't finished investigating but the only related validation I could find so far only checks that the index pattern is different than the rollup index name. It doesn't do any wildcard matching.

image

@alisonelizabeth
Copy link
Contributor

alisonelizabeth commented Apr 11, 2020

I think the regression here is that we are no longer surfacing the error caused_by reason from ES in the callout description, which provides a little more context about the error. I remember running into a related bug when testing the client NP migration PR, but I thought it was resolved. Related comment: #53503 (comment).

@cuff-links cuff-links changed the title [Rollups][ES-UI] 400 Error when Trying to Create a New Rollup [Rollups][ES-UI] No Error Message Shown for when Rollup Matches All Indices Apr 17, 2020
@spalger spalger added v7.7.1 and removed v7.7.0 labels May 14, 2020
@wylieconlon
Copy link
Contributor

I am still running into this confusing error message on master, it seems like we should validate that the rollup pattern matches all indices before allowing the user to create a rollup.

@alisonelizabeth
Copy link
Contributor

Thanks for raising this again @wylieconlon.

it seems like we should validate that the rollup pattern matches all indices before allowing the user to create a rollup.

👍

Note the issue with the confusing error message is related to #84801.

@cjcenizal cjcenizal removed their assignment Sep 7, 2022
@alisonelizabeth
Copy link
Contributor

Rollups was deprecated in 8.11 and therefore we will not be prioritizing enhancements or bugfixes.

@alisonelizabeth alisonelizabeth closed this as not planned Won't fix, can't repro, duplicate, stale Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Rollups Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.7.1
Projects
None yet
Development

No branches or pull requests

6 participants