Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest manager] Namespace should not accept empty string. #67473

Closed
ph opened this issue May 27, 2020 · 7 comments · Fixed by #67492
Closed

[Ingest manager] Namespace should not accept empty string. #67473

ph opened this issue May 27, 2020 · 7 comments · Fixed by #67492
Assignees
Labels
blocker Ingest Management:alpha1 Group issues for ingest management alpha1 Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@ph
Copy link
Contributor

ph commented May 27, 2020

it's possible to enter an empty string for the namespace box when adding or modifiying a datasource.
We should:

  • Not allow an empty string.
  • Use "default' as the default value.

Having an empty string will cause issues in Elasticsearch.

 FATAL  [illegal_argument_exception] The provided expression [logs-redis.log-] matches a data stream, specify the corresponding concrete indices instead. :: {"path":"/_alias/.kibana_k8s","query":{},"statusCode":400,"response":"{\"error\":{\"root_cause\":[{\"type\":\"illegal_argument_exception\",\"reason\":\"The provided expression [logs-redis.log-] matches a data stream, specify the corresponding concrete indices instead.\"}],\"type\":\"illegal_argument_exception\",\"reason\":\"The provided expression [logs-redis.log-] matches a data stream, specify the corresponding concrete indices instead.\"},\"status\":400}"}
@ph ph added blocker Team:Fleet Team label for Observability Data Collection Fleet team Ingest Management:alpha1 Group issues for ingest management alpha1 labels May 27, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@ph
Copy link
Contributor Author

ph commented May 27, 2020

We have a guard in 7.8 for the agent, elastic/beats#18769 but we should have the same guard in the UI to generate valid configuration.

In 7.8 we will massage the configuration to make it valid but 7.9 we will fail hard.

@nchaulet
Copy link
Member

@ph how different this is from #65666 ?

@ph
Copy link
Contributor Author

ph commented May 27, 2020

@nchaulet I think the main difference is to make sure we have a value for 7.8, #65666 seems to be more complicated to implement ?

@nchaulet
Copy link
Member

I think it's probably not going to be more complicated to do #65666 directly @jen-huang correct me if I am wrong here

@ph
Copy link
Contributor Author

ph commented May 27, 2020

@nchaulet Well, I think its more a matter of risk here for 7.8, which one appear to be less risky?

@nchaulet
Copy link
Member

nchaulet commented May 27, 2020

Yes let do the fix to not accept empty string and modify the UI in an another step for 7.9 👍Going to work on the fix this morning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker Ingest Management:alpha1 Group issues for ingest management alpha1 Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants