[Ingest Manager] Do not allow empty namespace #67492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchaulet
added
bug
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
nchaulet
added
the
release_note:skip
neptunian
approved these changes
May 27, 2020
|
I think this change will impact the data resources provider we have in Endpoint Functional test (which are currently disabled). I will keep this in mind when re-enabling them. @elastic/endpoint-management FYI ^ |
💚 Build SucceededTo update your PR or re-run it, just comment with: |
nchaulet
added a commit
to nchaulet/kibana
that referenced
this pull request
May 27, 2020
nchaulet
added a commit
to nchaulet/kibana
that referenced
this pull request
May 27, 2020
ruflin
reviewed
May 27, 2020
| @@ -9,7 +9,7 @@ import { AgentConfigStatus } from '../../../common'; | |||
|
|
|||
| const AgentConfigBaseSchema = { | |||
| name: schema.string(), | |||
| namespace: schema.maybe(schema.string()), | |||
| namespace: schema.string({ minLength: 1 }), | |||
There was a problem hiding this comment.
@nchaulet Can we use this to also do some validation? For example namespace should not contain - as an example.
There was a problem hiding this comment.
Yes we can provide a validate function, where we can add all the custom logic we want
nchaulet
added a commit
that referenced
this pull request
May 27, 2020
nchaulet
added a commit
that referenced
this pull request
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolve #67473
We should not allow empty namespace as it broke Kibana.
This PR add server side validation to avoid empty namespace, I did not add any client side validation as @jen-huang is currently working on this form #66298
Also done in this PR:
UI example