Saved object import shows inaccurate error count

[jportner]

Kibana version: 7.8

Describe the bug: When processing a saved object import that results in reference errors, the error count is inaccurate.

Steps to reproduce:

1. Start Kibana and load up eCommerce sample data
2. Delete the index pattern
3. Export the Dashboard, including references
4. Import the new NDJSON file

Expected behavior: The error count should equal 9, instead it appears to be 16.

Screenshots (if relevant):

"Import saved objects" flyout:

Debugging and checking the object state reveals that several duplicates of import objects are included:

[elasticmachine]

Pinging @elastic/kibana-security (Team:Security)

[jportner]

This is happening because some objects have multiple references to an index pattern, and each reference is getting counted as an error (line 72):

kibana/src/plugins/saved_objects_management/public/lib/process_import_response.ts

Lines 51 to 91 in 2d1312f

	export function processImportResponse(
	response: SavedObjectsImportResponse
	): ProcessedImportResponse {
	// Go through the failures and split between unmatchedReferences and failedImports
	const failedImports = [];
	const unmatchedReferences = new Map();
	for (const { error, ...obj } of response.errors || []) {
	failedImports.push({ obj, error });
	if (error.type !== 'missing_references') {
	continue;
	}
	// Currently only supports resolving references on index patterns
	const indexPatternRefs = error.references.filter((ref) => ref.type === 'index-pattern');
	for (const missingReference of indexPatternRefs) {
	const conflict = unmatchedReferences.get(
	`${missingReference.type}:${missingReference.id}`
	) || {
	existingIndexPatternId: missingReference.id,
	list: [],
	newIndexPatternId: undefined,
	};
	conflict.list.push(obj);
	unmatchedReferences.set(`${missingReference.type}:${missingReference.id}`, conflict);
	}
	}
	return {
	failedImports,
	unmatchedReferences: Array.from(unmatchedReferences.values()),
	// Import won't be successful in the scenario unmatched references exist, import API returned errors of type unknown or import API
	// returned errors of type missing_references.
	status:
	unmatchedReferences.size === 0 &&
	!failedImports.some((issue) => issue.error.type === 'conflict')
	? 'success'
	: 'idle',
	importCount: response.successCount,
	conflictedSavedObjectsLinkedToSavedSearches: undefined,
	conflictedSearchDocs: undefined,
	};
	}

[legrego]

Resolved via #75444