Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default map-tiles provider to configuration file #7050

Closed
pandrese opened this issue Apr 26, 2016 · 6 comments
Closed

Add default map-tiles provider to configuration file #7050

pandrese opened this issue Apr 26, 2016 · 6 comments

Comments

@pandrese
Copy link

Today the map-tiles provider is hard coded in src/ui/public/vislib/visualizations/_map.js.

This should be made configurable in config/kibana.yml like is the case for WMS map-tiles.

@rashidkpc
Copy link
Contributor

seems reasonable, thought I would put the configuration in the advanced settings screen instead of in kibana.yml

@pandrese
Copy link
Author

pandrese commented May 2, 2016

That would also solve my use case. Basically I want to avoid to patch Kibana every time I install a new version.

Putting the configuration in kibana.yml would be enough for me, but adding it to the advanced setting screen is probably even better.

@epixa
Copy link
Contributor

epixa commented Jul 20, 2016

This change went in via #7724, and it is now available in 4.5.3 and 4.1.10.

@epixa epixa closed this as completed Jul 20, 2016
@jayeshmori
Copy link

jayeshmori commented Jul 21, 2016

I have developed a fix to make mapTiles configurable from advanced settings. I see the issue is closed but I can submit a pull request if you guys are still interested in it.

@epixa
Copy link
Contributor

epixa commented Jul 21, 2016

@jayeshmori I'd love to take a look at a PR if you want to put it together. Honestly, we're still trying to figure out whether we'd ultimately move it to advanced settings or not, so having a working implementation to serve as context would be helpful. Thanks!

@jayeshmori
Copy link

@epixa - I will clean it up and send it your way over the weekend. I will try to put some context about the use case as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants