Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move plugin data path to project root #7519

Closed
jbudz opened this issue Jun 21, 2016 · 2 comments
Closed

Move plugin data path to project root #7519

jbudz opened this issue Jun 21, 2016 · 2 comments
Assignees

Comments

@jbudz
Copy link
Member

jbudz commented Jun 21, 2016

From #7457 (comment)

Currently, Kibana installs external plugins to installedPlugins and plugin data to installedPlugins/.data. The data path implies that this is only meant for external plugins. Moving this to the root directory will give all plugins a location to write to.

@jbudz
Copy link
Member Author

jbudz commented Jun 21, 2016

If this is moved to the root directory, does it make sense to prefix with a . still?

@w33ble
Copy link
Contributor

w33ble commented Jun 21, 2016

I'm in favor of moving this to the root, or at least out of installedPlugins, as making the distinction between internal and external plugins is odd. It also creates more work as we'd require 2 data paths, and if we want to take something external and make it internal, we have to update the plugin to use the "right" path.

As for removing the . prefix, it's not so much about hiding it as it is about not concerning users with it, so I could go either way.

@jbudz jbudz self-assigned this Jun 27, 2016
@jbudz jbudz mentioned this issue Jun 28, 2016
@jbudz jbudz removed the discuss label Jul 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants