[build] Add data directory for plugins #7457
Conversation
|
Nice! Are there any plans to expose the |
|
Good call, it definitely should. I'm not quite sure on implementation yet but it's on the list. |
Is there an issue you can cross-link? |
|
Checkbox one of #7275 |
|
@w33ble gave it a go adding it to our config object. Names match https://www.elastic.co/guide/en/elasticsearch/reference/master/rpm.html#rpm-layout |
| @@ -95,6 +96,11 @@ module.exports = () => Joi.object({ | |||
| initialize: Joi.boolean().default(true) | |||
| }).default(), | |||
|
|
|||
| path: Joi.object({ | |||
| data: Joi.string().default(getData()), | |||
| conf: Joi.string().default(getConfig()) | |||
There was a problem hiding this comment.
this should probably be removed, at this point it's already loaded
jbudz
force-pushed
the
issues/7157
branch
3 times, most recently
from
cf64bc0 to
16e8975
Compare
|
Updated reporting and used the setting, everything worked as expected. The only feedback I have is the use of I know the package changes already went in, so I'm OK leaving this alone for now, but for the next release, it might be better to move Other than that, this LGTM! |
|
Opened #7519 |
--------- **Commit 1:** [build] Add data directory that plugins can write to. Closes #7157 * Original sha: 5b19534 * Authored by Jonathan Budzenski <jbudz@users.noreply.github.com> on 2016-06-14T16:50:40Z **Commit 2:** [config] Add path.conf, path.data * Original sha: 16e8975 * Authored by Jonathan Budzenski <jbudz@users.noreply.github.com> on 2016-06-16T16:17:51Z
[build] Add data directory for plugins Former-commit-id: 62f258b
Closes #7157, also part of #7275.
This adds a data directory that plugins can write files to. For archives, this live at installedPlugins/.data, and for packages at /var/lib/kibana.
The data folder path is added as part of the config object,
config.get('path.data')