Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support new half_float and scaled_float types in Console #7811

Closed
Bargs opened this issue Jul 22, 2016 · 2 comments
Closed

Support new half_float and scaled_float types in Console #7811

Bargs opened this issue Jul 22, 2016 · 2 comments
Assignees
@Bargs
Labels
Feature:Console Dev Tools Console Feature release_note:enhancement

Comments

@Bargs
Copy link
Contributor

Bargs commented Jul 22, 2016

While working on #7789 we couldn't figure out the most appropriate autocomplete value scaling_factor. Either we need to figure out how to autocomplete only the name, leaving the value blank, or we should come up with the most sensible default.

@jpountz if Console's autocomplete requires a default value, do you have any thoughts on what a good default would be? Should there be a default in ES as well?

Related: #7782
Related: elastic/elasticsearch#19264
@Bargs Bargs self-assigned this Jul 22, 2016
@jpountz
Copy link

jpountz commented Jul 22, 2016

I like scaling_factor to be explicit since it has direct consequences on accuracy and disk usage. I'd be willing to reconsider however if there is consensus that we need to add a default.

If we need to have a default in Console, I think I would use 100: this gives 2 decimal places.

Bargs added a commit to Bargs/kibana that referenced this issue Jul 26, 2016
@Bargs
Add new float support to console autocomplete
a413b5c 
Elasticsearch added a couple new data types, half_float and
scaled_float, so we should include those in Console's autocomplete
suggestions for mappings. Scaled_float also has a required parameter
called scaling_factor, which we suggest a sensible default for when
autocompleted. We talked about leaving the value empty, forcing the user
to pick a value, but the autocompleter doesn't seem to support blank
values.

Fixes: elastic#7811
Related: elastic#7782
@Bargs Bargs mentioned this issue Jul 26, 2016
Merged
@Bargs
Copy link
Contributor Author

Bargs commented Jul 26, 2016

Thanks @jpountz!

airow pushed a commit to airow/kibana that referenced this issue Feb 16, 2017
@Bargs
Add new float support to console autocomplete
b6c88a3 
Elasticsearch added a couple new data types, half_float and
scaled_float, so we should include those in Console's autocomplete
suggestions for mappings. Scaled_float also has a required parameter
called scaling_factor, which we suggest a sensible default for when
autocompleted. We talked about leaving the value empty, forcing the user
to pick a value, but the autocompleter doesn't seem to support blank
values.

Fixes: elastic#7811
Related: elastic#7782

Former-commit-id: a413b5c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bargs Bargs

Labels
Feature:Console Dev Tools Console Feature release_note:enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpountz @Bargs