Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Accessibility) Remove instance of deprecated EuiKeyboardAccessible #81058

Closed
myasonik opened this issue Oct 19, 2020 · 5 comments
Closed

(Accessibility) Remove instance of deprecated EuiKeyboardAccessible #81058

myasonik opened this issue Oct 19, 2020 · 5 comments
Labels
blocked :DataDiscovery/fix-it-week Feature:Graph Graph application feature loe:small Small Level of Effort Project:Accessibility Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. WCAG A

Comments

@myasonik
Copy link
Contributor

EuiKeyboardAccessible was deprecated because it was abused more often than it was used successfully so we need to remove it from Kibana before December 2020.

It seems in Graph it's used as a workaround for a different EUI bug: https://github.com/elastic/kibana/blob/master/x-pack/plugins/graph/public/components/field_manager/field_editor.tsx#L208-L211

This workaround creates an empty button (no name, no action, etc) which can be confusing for both screen reader and keyboard users.

If removing it still causes issues, please open an issue with EUI so that it can be resolved.
@myasonik myasonik added Project:Accessibility Feature:Graph Graph application feature WCAG A loe:small Small Level of Effort Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Oct 19, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293 flash1293 self-assigned this Nov 3, 2020
@flash1293 flash1293 mentioned this issue Nov 3, 2020
Closed
@flash1293
Copy link
Contributor

This is currently not fixable in a nice way due to an EUI limitation: elastic/eui#4216

@flash1293 flash1293 mentioned this issue Nov 4, 2020
Merged
6 tasks
@myasonik
Copy link
Contributor Author

myasonik commented Apr 6, 2021

Seems like the blocking issue is now closed, removing the blocked label.

Pinging here as a reminder that this will be removed from EUI in June.

@flash1293 flash1293 removed their assignment Jul 9, 2021
@timroes timroes added :VisEditors:fix-it-week Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. and removed :KibanaApp/fix-it-week Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Sep 2, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@timroes
Copy link
Contributor

timroes commented Sep 7, 2021

This seems to be resolved in the meantime.

@timroes timroes closed this as completed Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked :DataDiscovery/fix-it-week Feature:Graph Graph application feature loe:small Small Level of Effort Project:Accessibility Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. WCAG A
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@timroes @flash1293 @myasonik @elasticmachine