Deprecating EuiKeyboardAccessible #4135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myasonik
added
accessibility
deprecations
myasonik
commented
Oct 14, 2020
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4135/ |
myasonik
force-pushed
the
deprecate-EuiKeyboardAccessible
branch
from
c0c515f to
f7cdaf4
Compare
myasonik
force-pushed
the
deprecate-EuiKeyboardAccessible
branch
from
f7cdaf4 to
eed5d59
Compare
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4135/ |
cchaos
suggested changes
Oct 15, 2020
added 2 commits
October 15, 2020 15:24
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4135/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4135/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4135/ |
thompsongl
reviewed
Oct 15, 2020
|
One thing real quick is that CI is throwing this error because you probably forgot to change a token key when copy/pasting. 18:26:55 Token euiStepStrings.warning has two differing defaults:
18:26:55 Step {number} has warnings
18:26:55 Step {number}: {title} has warnings |
cchaos
approved these changes
Oct 19, 2020
thompsongl
approved these changes
Oct 19, 2020
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com> Co-authored-by: Greg Thompson <thompson.glowe@gmail.com>
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4135/ |
cchaos
reviewed
Oct 19, 2020
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4135/ |
This was referenced Oct 19, 2020
This was referenced Oct 21, 2020
kshitij86
added a commit
to kshitij86/eui
that referenced
this pull request
Nov 29, 2020
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com> Co-authored-by: Greg Thompson <thompson.glowe@gmail.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3838. After this PR is merged, should update the deprecation schedule to include removing EuiKeyboardAccessible and create another issue for addressing EuiBasicTable's a11y issues which are outside the scope of this deprecation.
Adds docs about deprecation
Fixes EuiCodeEditor
Though EuiCodeEditor didn't use EuiKeyboardAccessible, because it mentioned it in the comments, it came up in this work. It used EuiKeyboardAccessible as a template for how to fix a problem that was better fixed other ways.
Fixes EuiStepsHorizontal
While removing the use of EuiKeyboardAccessible, also took the opportunity to fix up a few other a11y issues with the component, simplify its semantics, and align its string usage across all instances.
Ignores EuiBasicTable
EuiBasicTable uses EuiKeyboardAccessible but unwinding that decision would be a whole can of worms. To deprecate EuiKeyboardAccessible as quickly as possible, pushing off any EuiBasicTable work till a decision on how to deal with it can be reached.
Checklist