Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Remove "delete policy" button for policies which cannot be deleted #95226

Closed
hbharding opened this issue Mar 23, 2021 · 3 comments · Fixed by #98962
Closed

[Fleet] Remove "delete policy" button for policies which cannot be deleted #95226

hbharding opened this issue Mar 23, 2021 · 3 comments · Fixed by #98962
Assignees
@jfsiii
Labels
enhancement New value added to drive a business result low hanging fruit DO NOT USE. Use `good first issue` instead Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@hbharding
Copy link
Contributor

hbharding commented Mar 23, 2021 •
edited
Loading

Problem

For policies such as Default policy and Elastic Cloud policy (naming TBD) that are created automatically by the system and cannot be deleted, we should not show a disabled "delete policy" button since users will never be able to take this action in the UI.

image

Solution

  • Remove the "Delete policy" section on the agent policy settings tab for policies that cannot be deleted
@hbharding hbharding added enhancement New value added to drive a business result Team:Fleet Team label for Observability Data Collection Fleet team labels Mar 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@jfsiii jfsiii mentioned this issue Apr 2, 2021
Closed
23 tasks
@hbharding hbharding mentioned this issue Apr 14, 2021
Closed
@jen-huang jen-huang added the low hanging fruit DO NOT USE. Use `good first issue` instead label Apr 28, 2021
@jfsiii
Copy link
Contributor

jfsiii commented Apr 30, 2021

This was (5a) from elastic/observability-design#32, Do not show the “Delete policy” section for Hosted agent policies

It was closed in #96337

@jfsiii jfsiii closed this as completed Apr 30, 2021
@jen-huang
Copy link
Contributor

@jfsiii This behaves correctly for hosted agent policies, but a fix needs to be made to hide it for is_default policies too:

image

@jen-huang jen-huang reopened this Apr 30, 2021
@jfsiii jfsiii mentioned this issue Apr 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jfsiii jfsiii

Labels
enhancement New value added to drive a business result low hanging fruit DO NOT USE. Use `good first issue` instead Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fleet] Hide delete policy button for default policies jfsiii/kibana
4 participants
@jfsiii @hbharding @jen-huang @elasticmachine