Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] UI changes related to hosted agent policies #91906

Closed
23 tasks done
jfsiii opened this issue Feb 18, 2021 · 22 comments · Fixed by #97517
Closed
23 tasks done

[Fleet] UI changes related to hosted agent policies #91906

jfsiii opened this issue Feb 18, 2021 · 22 comments · Fixed by #97517
Assignees
@jfsiii
Labels
Team:Fleet Team label for Observability Data Collection Fleet team v7.13.0

Comments

@jfsiii
Copy link
Contributor

jfsiii commented Feb 18, 2021 •
edited
Loading

https://github.com/elastic/observability-design/issues/32

  1. Show a lock icon with hover tooltip next to host policy names
  2. Agents enrolled in a hosted agent policy cannot be upgraded, unenrolled, or reassigned to a new policy
  3. Agents enrolled in a hosted agent policy should not be marked as "upgrade available" if using an earlier agent version
  4. Agents cannot be enrolled with a hosted agent policy.
  5. Users cannot delete, copy, or rename a hosted agent policy
  6. Users should not be able to revoke an enrollment token used by a hosted agent policy
  7. Users cannot add or remove integrations from a hosted agent policy
  8. [Fleet] Can't select managed agent. Bulk upgrade agent UI changes #96087 Bulk actions - users should not be able to select agents enrolled in a hosted agent policy
    • Disable the checkbox for agents enrolled in a hosted agent policy.
    • Change bulk actions button copy to "all agents selected"
    • When everything selected, the modal title uses "all selected agents" -> i.e. "upgrade all selected agents"
    • If the result of a bulk action has mixed success and errors, change the modal title & body
    • Change the "experimental" badge for the upgrade agent action modal to the beaker icon
@jfsiii jfsiii added the v7.13.0 label Feb 18, 2021
@jfsiii jfsiii assigned jfsiii, hbharding and mostlyjason and unassigned jfsiii Feb 18, 2021
@hbharding hbharding mentioned this issue Feb 19, 2021
Closed
@mostlyjason
Copy link
Contributor

@jfsiii thanks for filing this! It'd be good to have clear messaging about what managed agent policies are and how users should interact with them. Improving the error messages could be a first step in that direction. I filed this issue to improve the error messages #92591.

@mostlyjason
Copy link
Contributor

mostlyjason commented Feb 24, 2021 •
edited
Loading

  • General
    • The API allows (will allow) the restrictions to be bypassed by passing a parameter like force: true. Should the UI include anything to support that feature/workaround or should that be limited to the API?
      • @jfsiii Can you think of any use cases where a user might need the force parameter in the UI? If not, I'd say leave it to the API.
  • Agent Policy create view:
    • Do we allow the user to create a managed policy from the UI (e.g. add checkbox for is_managed)
      • That'd be nice but I worry we don't have enough RBAC controls to support this right now (see below). Kubernetes users could work around this using the API in the near term.
  • Agent Policy detail view:
    • Do we a) allow the user to update the is_managed property b) show the is_managed property as disabled c) leave it hidden?
      • The settings tab is a good place to give users visibility to the fact that a policy is managed, and show a description of what that means. The challenge is that a user should not be able to mark a policy managed by ESS/ECE as unmanaged in the UI. I believe this would allow users to unenroll agents, which should not be allowed. Is that true @jfsiii? We could make that checkbox disabled for now. Alternatively, we'd need more RBAC or a way to track whether it was set by ESS/ECE or the user, and I worry that adds additional scope.
  • Agent Policy list view:
    • any indication a policy is managed?
      • I'm not sure its necessary in this view if we provide visibility in the detail view
    • Do we disable actions which are forbidden on managed policies like "add agent"?
      • If it was disabled users would not have any context about why it is disabled. It might be better to enable it, then show an error message that its not allowed and why to provide more explanation.
  • Agents list view:
    • If it's already enrolled in a managed policy, do we disable forbidden actions like "assign to a new policy" and "unenroll agent"
      • Same reasoning here: if it was disabled users would not have any context about why it is disabled. An error message gives more context and can guide users to the proper way to achieve these use cases. Plain text could be a starting point, but it'd be even better if we could detect what orchestration solution they are using and link them to the proper place, such as the cloud console. I'm worried this increases the scope and we could do that later if it will take substantially longer.
    • Agents enrolled in managed policies cannot be upgraded. How does this affect the "upgrade available" row badging? Do we show still show the badge but style it differently, hide the badge? How does this affect the "upgrade available"? Should agents which cannot be upgraded be shown when the "upgrade available" filter is active?
      • I think users will appreciate visibility to upgrades, but they cannot upgrade them in this UI. We could apply our same reasoning that we enable the upgrade button, but if they click it we show an error message with more context about why they can't do it, and where they should go to perform an upgrade. One challenge is how this interacts with the bulk select feature. Lets start the discussion here [Fleet] [Managed Policies] Bulk actions changes #90437

@jfsiii
Copy link
Contributor Author

jfsiii commented Feb 24, 2021

Can you think of any use cases where a user might need the force parameter in the UI? If not, I'd say leave it to the API.

No. I think it makes sense to leave leave all "workarounds" to the API layer.

@mostlyjason I updated the description to the decisions and call out any remaining work. Let me know if I missed or misunderstood something.

@mostlyjason
Copy link
Contributor

@hbharding do you have any input on this one? There is overlap with UX here.

@hbharding
Copy link
Contributor

re: disabling actions, Jason is spot on, "users would not have any context about why it is disabled"; however, showing them as available actions which we know will lead to API errors is not a good UX. It's one that could frustrate our users. It would be much better to provide descriptions upfront about why an action is unavailable. Many of these actions appear in context menus, and EUI has an easy way to provide descriptions via tooltips (check first example). For other actions that appear as regular buttons, we could wrap those with tooltips as well. Something generic like "This action is not available for agents enrolled with a managed agent policy" or "This action is not available for managed agent policies" would be better than our current API errors:
image

Other thoughts below:

  • General
    • The API allows (will allow) the restrictions to be bypassed by passing a parameter like force: true. Should the UI include anything to support that feature/workaround or should that be limited to the API?
  • Agent Policy create view:
    • Do we allow the user to create a managed policy from the UI (e.g. add checkbox for is_managed)
      • From Jason: That'd be nice but I worry we don't have enough RBAC controls to support this right now (see below). Kubernetes users could work around this using the API in the near term.
      • @mostlyjason I think creating a managed policy is separate concern from being able to edit a managed policy. With that said, I'm totally fine with "no, we don't need this" to simplify, but I just want to make sure we're not overlooking any use cases for this. For example, if a user wants to set up a new Fleet Server, would they have the need to create a new managed policy so they can add the Fleet Server integration to it? Or are we limiting users to only use the default managed policy that we bootstrap. A similar use case might be for APM.
  • Agent Policy detail view:
    • Do we a) allow the user to update the is_managed property b) show the is_managed property as disabled c) leave it hidden?
      • From Jason: The settings tab is a good place to give users visibility to the fact that a policy is managed, and show a description of what that means.
      • Putting this on the settings page would imply that unmanaged policies can be changed into managed policies, which I don't think we have a use case for. I also don't think it's very visible. A more appropriate place might be in the header of the agent policy detail page where we list other key/value pairs, but that area is already quite crowded. I think its important that we give visibility that it's a managed policy and provide a description (probably via tooltip). Another idea would be to use an icon next to the policy name on the detail page which would show a tooltip describing what a managed policy is.
  • Agent Policy list view:
    • any indication a policy is managed?
      • We could add a small icon at the end of the policy name to indicate if its managed. Perhaps a "lock" icon would be appropriate.
    • Do we disable actions which are forbidden on managed policies like "add agent"?
      • see response at top
  • Agents list view:
    • If it's already enrolled in a managed policy, do we disable forbidden actions like "assign to a new policy" and "unenroll agent"
      • yup. see response at top
    • Agents enrolled in managed policies cannot be upgraded. How does this affect the "upgrade available" row badging? Do we show still show the badge but style it differently, hide the badge? How does this affect the "upgrade available"? Should agents which cannot be upgraded be shown when the "upgrade available" filter is active?
      • I agree with Jason, seeing the badge may be helpful, even when filter is applied. See response up top about disabling the action.

Another area we may need to consider is the "Add Integration" button on the Agent Policy detail page:

see screenshot

image

image

Do we need to disable this action, or are we allowing for some integrations to be added to managed policies? If the later, do we need an issue to limit what integrations will appear in that list?

@mostlyjason
Copy link
Contributor

It would be much better to provide descriptions upfront about why an action is unavailable. Many of these actions appear in context menus, and EUI has an easy way to provide descriptions via tooltips

++ tooltips sound like a better way to provide context

think creating a managed policy is separate concern from being able to edit a managed policy.

++ this allows users flexibility while matching our cloud restrictions. This could be an advanced option in the create agent policy dialog. We only have two options today, but plan to have more in the future.

A more appropriate place might be in the header of the agent policy detail page where we list other key/value pairs, but that area is already quite crowded.

Good idea. If we show header text like Policy Type: Managed then they mouse over, they could see a tooltip with a definition of managed. This will be nice when we have central type policies in the future. Otherwise we might have multiple icons to indicate different types which might be tricky. Do we really need the number of integrations up there, since its visible in the table below? We could swap that out to make space for it. This is also more discoverable than a tooltip on the policy name.

Do we need to disable this action, or are we allowing for some integrations to be added to managed policies? If the later, do we need an issue to limit what integrations will appear in that list?

We should disable it in 7.13, but later we'll have a allowlist/blocklist for specific integrations. We can come back to that later when we implement it.

@ruflin ruflin added the Team:Fleet Team label for Observability Data Collection Fleet team label Feb 25, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@ph ph assigned jfsiii and unassigned hbharding and mostlyjason Feb 25, 2021
@ph
Copy link
Contributor

ph commented Mar 1, 2021

After talking @jfsiii last week, seems we have enough on our side to make some progress on the implementation.

@mostlyjason
Copy link
Contributor

Great thanks! @hbharding can you comment on the option to replace the number of integrations with the policy type (see details in the comments above)

Also, disabling the unenroll menu item will also prevent users from force unenrolling agents in a managed policy in the UI #88688 (comment)

@hbharding
Copy link
Contributor

hbharding commented Mar 3, 2021 •
edited by jfsiii
Loading

I'll add some designs for this later today to close the loop. @mostlyjason I think it's fine to remove the integration count from the header.

Also, disabling the unenroll menu item will also prevent users from force unenrolling agents in a managed policy in the UI

Are you saying this is a behavior we want to support for agents in managed policies? @ruflin's comment seemed to suggest that it should be blocked, and @jfsiii commented here that this should only be allowed via the API.

@mostlyjason
Copy link
Contributor

@hbharding I'm saying we should not allow users to unenroll agents in a managed policy in the UI. I think that's consistent with Ruflin and John's comments?

@mostlyjason mostlyjason mentioned this issue Mar 3, 2021
Closed
@hbharding
Copy link
Contributor

hbharding commented Mar 4, 2021 •
edited
Loading

@jfsiii I've put together some mocks that should account for everything discussed here. I can send you the Figma file if that's easier (don't want to post link here since it's a public issue)

Ability to create centrally managed agent policies

  • Updated: we don't need this
View old comment
  • In the "create agent policy" flyout, I added a section for "Agent policy type" under advanced options.
  • The available options are "Regular" (default) or "Externally managed"
  • @mostlyjason I could use help coming up with a description for this. I suggest we provide a brief description of what the 2 policies types are for. Open to other ideas. This description will also appear on the settings tab on the agent policy detail view.

image

A way to give visibility on agent policy type

  • Update: Leaning towards using an icon next to agent policy name to give visibility. See my later comment.
View old comment
  • Since the policy type is defined under advanced options where other settings appear, I changed my mind and agree with Jason that it makes sense to include this on the settings tab on the agent policy detail view. The placement is consistent with how they appear in the "create agent policy" flyout.
  • The agent policy type input should appear disabled since it cannot be changed. I included a description below the input explaining so. We should reuse the same description that we use on the "create agent policy" flyout.
    image

Disable actions that are not allowed

  • As I described earlier, it's a better UX to disable an action and explain why rather than give the impression that an action is available when we know it will lead to an API error. There are a few places this can occur for 1) externally managed agent policies and 2) agents that are enrolled in an externally managed agent policy

Agent policy list view and detail view

  • We present actions in context menu on both the policy list view and detail view. "Add agent" should appear disabled with tooltip on hover. Text: This action is not available for externally managed agent policies
  • The "delete policy" button should appear disabled with tooltip on hover. Same text as above.
  • The "add integration" button should appear disabled with tooltip on hover. Same text as above.
    image
    image
    image

Agents view

  • The following actions should be disabled and show a tooltip on hover. Text: This action is not available for agents enrolled in an externally managed agent policy
    • Assign to new policy
    • Unenroll agent
    • Upgrade agent
  • These actions also appear on the agent detail page in the "actions" button and should be handled similarly.

image

Bulk actions

I'll include screenshots for that here #90437

@ruflin
Copy link
Contributor

ruflin commented Mar 4, 2021

We should not allow users to create a "externally managed policy" through the UI, this is an API only feature.

@hbharding
Copy link
Contributor

I forgot to account for an action the agent policy detail page. Users should not be able to delete an integration - this button in the context menu should be disabled and use the same tooltip description for other related actions.

@hbharding
Copy link
Contributor

hbharding commented Mar 9, 2021 •
edited
Loading

Jason's been working on doc to help come decision on how we refer to these special kinds of agent policies. It seems like we're leaning towards thinking about these as capabilities of agent policies rather than introducing "agent policy types", and we seem to like the word "restricted" to describe the capability we have in mind. I don't mean to rush the decision, but I want to call out that we'll need to update the language in these tooltips if we're not going to be using "externally managed".

re: "A way to give visibility of agent policy type", I no longer think we should be showing this as a disabled field called "Agent policy type" on the settings tab for agent policies.

How do others feel about using an icon next to the agent policy name, which could include a tooltip describing what it means. This "lock" icon feels appropriate and it would be helpful for providing context in several places.

image
image
image

@hbharding
Copy link
Contributor

@jfsiii hold off on adding the "policy type" to the agent policy detail view. We're leaning towards using an icon + tooltip (previous comment with screenshots). Waiting on Jason to finalize naming which may affect the the description we provide in the tooltip.

@mostlyjason mostlyjason changed the title [Fleet] UI changes related to managed agent policies [Fleet] UI changes related to hosted agent policies Mar 25, 2021
@mostlyjason
Copy link
Contributor

@hbharding we chatted about this live, but just adding a note that I think the next step here is to update the designs with the hosted agent policy wording

@hbharding
Copy link
Contributor

I provided updated designs for this here https://github.com/elastic/observability-design/issues/32. I wanted to create a separate issue to track work on our obs:design 7.13 board.

@jfsiii jfsiii mentioned this issue Apr 2, 2021
Merged
jfsiii pushed a commit that referenced this issue Apr 6, 2021
@kibanamachine
[Fleet] Hide many actions for hosted agent policies (#96160)
2adc060 
## Summary

Fixes items 2a, 4a, 5c2, and 6 from #91906

### 2a - On the agents table, remove all actions except for "View agent"

[code commit](a93dd8c) 

<img width="1090" alt="Screen Shot 2021-04-02 at 2 00 34 PM" src="https://user-images.githubusercontent.com/57655/113446102-1b40bd00-93c5-11eb-804b-2afec37a176b.png">
<img width="1100" alt="Screen Shot 2021-04-02 at 2 00 41 PM" src="https://user-images.githubusercontent.com/57655/113446103-1b40bd00-93c5-11eb-8aba-daa1aa539955.png">

### 4a & 5c2 On the agent policy list page, remove the "add agent" & "copy policy" actions which appears in the [...] actions menu
[code commit](f0c267f)
<img width="1067" alt="Screen Shot 2021-04-02 at 2 36 57 PM" src="https://user-images.githubusercontent.com/57655/113446281-7b376380-93c5-11eb-9f82-03e957e6656c.png">
<img width="1104" alt="Screen Shot 2021-04-02 at 2 37 02 PM" src="https://user-images.githubusercontent.com/57655/113446282-7bcffa00-93c5-11eb-942c-1a98ebbab385.png">


### 6 - Do not show the the "revoke token" trash icon

[code commit](cd05cd0)
<img width="1088" alt="Screen Shot 2021-04-02 at 2 15 54 PM" src="https://user-images.githubusercontent.com/57655/113446176-4a572e80-93c5-11eb-9740-9723c1cb9f50.png">

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine added a commit to kibanamachine/kibana that referenced this issue Apr 6, 2021
@kibanamachine
[Fleet] Hide many actions for hosted agent policies (elastic#96160)
1eddad6 
## Summary

Fixes items 2a, 4a, 5c2, and 6 from elastic#91906

### 2a - On the agents table, remove all actions except for "View agent"

[code commit](elastic@a93dd8c) 

<img width="1090" alt="Screen Shot 2021-04-02 at 2 00 34 PM" src="https://user-images.githubusercontent.com/57655/113446102-1b40bd00-93c5-11eb-804b-2afec37a176b.png">
<img width="1100" alt="Screen Shot 2021-04-02 at 2 00 41 PM" src="https://user-images.githubusercontent.com/57655/113446103-1b40bd00-93c5-11eb-8aba-daa1aa539955.png">

### 4a & 5c2 On the agent policy list page, remove the "add agent" & "copy policy" actions which appears in the [...] actions menu
[code commit](elastic@f0c267f)
<img width="1067" alt="Screen Shot 2021-04-02 at 2 36 57 PM" src="https://user-images.githubusercontent.com/57655/113446281-7b376380-93c5-11eb-9f82-03e957e6656c.png">
<img width="1104" alt="Screen Shot 2021-04-02 at 2 37 02 PM" src="https://user-images.githubusercontent.com/57655/113446282-7bcffa00-93c5-11eb-942c-1a98ebbab385.png">


### 6 - Do not show the the "revoke token" trash icon

[code commit](elastic@cd05cd0)
<img width="1088" alt="Screen Shot 2021-04-02 at 2 15 54 PM" src="https://user-images.githubusercontent.com/57655/113446176-4a572e80-93c5-11eb-9740-9723c1cb9f50.png">

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine added a commit that referenced this issue Apr 6, 2021
@kibanamachine
[Fleet] Hide many actions for hosted agent policies (#96160) (#96320)
3252416 
## Summary

Fixes items 2a, 4a, 5c2, and 6 from #91906

### 2a - On the agents table, remove all actions except for "View agent"

[code commit](a93dd8c) 

<img width="1090" alt="Screen Shot 2021-04-02 at 2 00 34 PM" src="https://user-images.githubusercontent.com/57655/113446102-1b40bd00-93c5-11eb-804b-2afec37a176b.png">
<img width="1100" alt="Screen Shot 2021-04-02 at 2 00 41 PM" src="https://user-images.githubusercontent.com/57655/113446103-1b40bd00-93c5-11eb-8aba-daa1aa539955.png">

### 4a & 5c2 On the agent policy list page, remove the "add agent" & "copy policy" actions which appears in the [...] actions menu
[code commit](f0c267f)
<img width="1067" alt="Screen Shot 2021-04-02 at 2 36 57 PM" src="https://user-images.githubusercontent.com/57655/113446281-7b376380-93c5-11eb-9f82-03e957e6656c.png">
<img width="1104" alt="Screen Shot 2021-04-02 at 2 37 02 PM" src="https://user-images.githubusercontent.com/57655/113446282-7bcffa00-93c5-11eb-942c-1a98ebbab385.png">


### 6 - Do not show the the "revoke token" trash icon

[code commit](cd05cd0)
<img width="1088" alt="Screen Shot 2021-04-02 at 2 15 54 PM" src="https://user-images.githubusercontent.com/57655/113446176-4a572e80-93c5-11eb-9740-9723c1cb9f50.png">

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: John Schulz <john.schulz@elastic.co>
@jfsiii jfsiii mentioned this issue Apr 7, 2021
Closed
@dikshachauhan-qasource
Copy link

dikshachauhan-qasource commented Apr 14, 2021 •
edited
Loading

Hi @EricDavisX

Today we have covered all the linked tickets and created 15 testcases from above merged PR.

Testcases Link is as follows:

For now we have cover all the scenarios nad changes for for below:

Please let us know if any further merges are available to cover.

Thanks
QAS

@simitt simitt mentioned this issue Apr 16, 2021
Closed
This was referenced Apr 16, 2021
Merged
Merged
jfsiii pushed a commit that referenced this issue Apr 19, 2021
@kibanamachine
Use <AgentPolicySummaryLine /> for consistent name+icon lockup (#97377)
2f4e9db 
## Summary

From design ticket https://github.com/elastic/observability-design/issues/32
> any ... place we display a link to the hosted agent policy, show an icon with hover tooltip:

This PR closes 1B + 1C from #91906 & two other places which followed the same pattern.

Factored out some repeated code at each call site into a `<AgentPolicySummaryLine />` component


<details><summary>Screenshots</summary>
<h3>Agent Policy List View</h3>
<img width="1103" alt="Screen Shot 2021-04-16 at 1 01 55 PM" src="https://user-images.githubusercontent.com/57655/115059112-18a99180-9eb4-11eb-9035-36a8e9db1f9d.png">

<h3>Agent List View</h3>
<img width="1185" alt="Screen Shot 2021-04-16 at 12 38 40 PM" src="https://user-images.githubusercontent.com/57655/115058885-bea8cc00-9eb3-11eb-8529-6f185fcac7d2.png">


<h3>Packaged Policy List View</h3>
<img width="1251" alt="Screen Shot 2021-04-16 at 10 23 49 AM" src="https://user-images.githubusercontent.com/57655/115058880-be103580-9eb3-11eb-8060-c501663af556.png">

<h3>Agent Policy Detail View</h3>
<img width="1145" alt="Screen Shot 2021-04-16 at 12 21 42 PM" src="https://user-images.githubusercontent.com/57655/115058883-bea8cc00-9eb3-11eb-9970-462ff4600fa4.png">



</details>

### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine added a commit to kibanamachine/kibana that referenced this issue Apr 19, 2021
@kibanamachine
Use <AgentPolicySummaryLine /> for consistent name+icon lockup (elast…
4003c1d 
…ic#97377)

## Summary

From design ticket elastic/observability-design#32
> any ... place we display a link to the hosted agent policy, show an icon with hover tooltip:

This PR closes 1B + 1C from elastic#91906 & two other places which followed the same pattern.

Factored out some repeated code at each call site into a `<AgentPolicySummaryLine />` component


<details><summary>Screenshots</summary>
<h3>Agent Policy List View</h3>
<img width="1103" alt="Screen Shot 2021-04-16 at 1 01 55 PM" src="https://user-images.githubusercontent.com/57655/115059112-18a99180-9eb4-11eb-9035-36a8e9db1f9d.png">

<h3>Agent List View</h3>
<img width="1185" alt="Screen Shot 2021-04-16 at 12 38 40 PM" src="https://user-images.githubusercontent.com/57655/115058885-bea8cc00-9eb3-11eb-8529-6f185fcac7d2.png">


<h3>Packaged Policy List View</h3>
<img width="1251" alt="Screen Shot 2021-04-16 at 10 23 49 AM" src="https://user-images.githubusercontent.com/57655/115058880-be103580-9eb3-11eb-8060-c501663af556.png">

<h3>Agent Policy Detail View</h3>
<img width="1145" alt="Screen Shot 2021-04-16 at 12 21 42 PM" src="https://user-images.githubusercontent.com/57655/115058883-bea8cc00-9eb3-11eb-9970-462ff4600fa4.png">



</details>

### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine added a commit that referenced this issue Apr 19, 2021
@kibanamachine
Use <AgentPolicySummaryLine /> for consistent name+icon lockup (#97377)…
ca84475 
… (#97441)

## Summary

From design ticket elastic/observability-design#32
> any ... place we display a link to the hosted agent policy, show an icon with hover tooltip:

This PR closes 1B + 1C from #91906 & two other places which followed the same pattern.

Factored out some repeated code at each call site into a `<AgentPolicySummaryLine />` component


<details><summary>Screenshots</summary>
<h3>Agent Policy List View</h3>
<img width="1103" alt="Screen Shot 2021-04-16 at 1 01 55 PM" src="https://user-images.githubusercontent.com/57655/115059112-18a99180-9eb4-11eb-9035-36a8e9db1f9d.png">

<h3>Agent List View</h3>
<img width="1185" alt="Screen Shot 2021-04-16 at 12 38 40 PM" src="https://user-images.githubusercontent.com/57655/115058885-bea8cc00-9eb3-11eb-8529-6f185fcac7d2.png">


<h3>Packaged Policy List View</h3>
<img width="1251" alt="Screen Shot 2021-04-16 at 10 23 49 AM" src="https://user-images.githubusercontent.com/57655/115058880-be103580-9eb3-11eb-8060-c501663af556.png">

<h3>Agent Policy Detail View</h3>
<img width="1145" alt="Screen Shot 2021-04-16 at 12 21 42 PM" src="https://user-images.githubusercontent.com/57655/115058883-bea8cc00-9eb3-11eb-9970-462ff4600fa4.png">



</details>

### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: John Schulz <john.schulz@elastic.co>
jfsiii pushed a commit that referenced this issue Apr 19, 2021
@kibanamachine
[Fleet] Filter hosted policies from menu (#97380)
17ecb04 
## Summary

 * 4C & 7C from #91906 about hiding hosted agent policy from select menus
 * Also changed reassign agent to new policy UI from flyout to modal as requested
<details><summary>Screenshots</summary>

<h3>Current</h3>
<img width="1090" alt="Screen Shot 2021-04-16 at 1 37 02 PM" src="https://user-images.githubusercontent.com/57655/115075124-9d9ea600-9ec8-11eb-8e88-d8f14f62613f.png">


<h3>PR</h3>
<img width="1092" alt="Screen Shot 2021-04-16 at 1 43 51 PM" src="https://user-images.githubusercontent.com/57655/115075127-9d9ea600-9ec8-11eb-8c47-c3b1fbeb96eb.png">

<h3>current</h3>
<img width="1112" alt="Screen Shot 2021-04-16 at 1 44 41 PM" src="https://user-images.githubusercontent.com/57655/115075129-9e373c80-9ec8-11eb-9f93-cac511c9d53d.png">

<h3>PR</h3>
<img width="1106" alt="Screen Shot 2021-04-16 at 1 50 28 PM" src="https://user-images.githubusercontent.com/57655/115075130-9e373c80-9ec8-11eb-93fb-0adfa5ae81ba.png">


<h3>current</h3>
<img width="1106" alt="Screen Shot 2021-04-16 at 1 35 48 PM" src="https://user-images.githubusercontent.com/57655/115075121-9d9ea600-9ec8-11eb-8605-89336371938b.png">

<h3>PR</h3>
<img width="1106" alt="Screen Shot 2021-04-16 at 2 35 15 PM" src="https://user-images.githubusercontent.com/57655/115075133-9ecfd300-9ec8-11eb-9458-0b7f9cf76c10.png">

<img width="2136" alt="Screen Shot 2021-04-16 at 3 24 16 PM" src="https://user-images.githubusercontent.com/57655/115075141-a0010000-9ec8-11eb-896c-efc4be4be5ac.png">

</details>

### Checklist
- [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine added a commit to kibanamachine/kibana that referenced this issue Apr 19, 2021
@kibanamachine
[Fleet] Filter hosted policies from menu (elastic#97380)
2d51c13 
## Summary

 * 4C & 7C from elastic#91906 about hiding hosted agent policy from select menus
 * Also changed reassign agent to new policy UI from flyout to modal as requested
<details><summary>Screenshots</summary>

<h3>Current</h3>
<img width="1090" alt="Screen Shot 2021-04-16 at 1 37 02 PM" src="https://user-images.githubusercontent.com/57655/115075124-9d9ea600-9ec8-11eb-8e88-d8f14f62613f.png">


<h3>PR</h3>
<img width="1092" alt="Screen Shot 2021-04-16 at 1 43 51 PM" src="https://user-images.githubusercontent.com/57655/115075127-9d9ea600-9ec8-11eb-8c47-c3b1fbeb96eb.png">

<h3>current</h3>
<img width="1112" alt="Screen Shot 2021-04-16 at 1 44 41 PM" src="https://user-images.githubusercontent.com/57655/115075129-9e373c80-9ec8-11eb-9f93-cac511c9d53d.png">

<h3>PR</h3>
<img width="1106" alt="Screen Shot 2021-04-16 at 1 50 28 PM" src="https://user-images.githubusercontent.com/57655/115075130-9e373c80-9ec8-11eb-93fb-0adfa5ae81ba.png">


<h3>current</h3>
<img width="1106" alt="Screen Shot 2021-04-16 at 1 35 48 PM" src="https://user-images.githubusercontent.com/57655/115075121-9d9ea600-9ec8-11eb-8605-89336371938b.png">

<h3>PR</h3>
<img width="1106" alt="Screen Shot 2021-04-16 at 2 35 15 PM" src="https://user-images.githubusercontent.com/57655/115075133-9ecfd300-9ec8-11eb-9458-0b7f9cf76c10.png">

<img width="2136" alt="Screen Shot 2021-04-16 at 3 24 16 PM" src="https://user-images.githubusercontent.com/57655/115075141-a0010000-9ec8-11eb-896c-efc4be4be5ac.png">

</details>

### Checklist
- [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine added a commit that referenced this issue Apr 19, 2021
@kibanamachine
[Fleet] Filter hosted policies from menu (#97380) (#97460)
759900f 
## Summary

 * 4C & 7C from #91906 about hiding hosted agent policy from select menus
 * Also changed reassign agent to new policy UI from flyout to modal as requested
<details><summary>Screenshots</summary>

<h3>Current</h3>
<img width="1090" alt="Screen Shot 2021-04-16 at 1 37 02 PM" src="https://user-images.githubusercontent.com/57655/115075124-9d9ea600-9ec8-11eb-8e88-d8f14f62613f.png">


<h3>PR</h3>
<img width="1092" alt="Screen Shot 2021-04-16 at 1 43 51 PM" src="https://user-images.githubusercontent.com/57655/115075127-9d9ea600-9ec8-11eb-8c47-c3b1fbeb96eb.png">

<h3>current</h3>
<img width="1112" alt="Screen Shot 2021-04-16 at 1 44 41 PM" src="https://user-images.githubusercontent.com/57655/115075129-9e373c80-9ec8-11eb-9f93-cac511c9d53d.png">

<h3>PR</h3>
<img width="1106" alt="Screen Shot 2021-04-16 at 1 50 28 PM" src="https://user-images.githubusercontent.com/57655/115075130-9e373c80-9ec8-11eb-93fb-0adfa5ae81ba.png">


<h3>current</h3>
<img width="1106" alt="Screen Shot 2021-04-16 at 1 35 48 PM" src="https://user-images.githubusercontent.com/57655/115075121-9d9ea600-9ec8-11eb-8605-89336371938b.png">

<h3>PR</h3>
<img width="1106" alt="Screen Shot 2021-04-16 at 2 35 15 PM" src="https://user-images.githubusercontent.com/57655/115075133-9ecfd300-9ec8-11eb-9458-0b7f9cf76c10.png">

<img width="2136" alt="Screen Shot 2021-04-16 at 3 24 16 PM" src="https://user-images.githubusercontent.com/57655/115075141-a0010000-9ec8-11eb-896c-efc4be4be5ac.png">

</details>

### Checklist
- [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: John Schulz <john.schulz@elastic.co>
@jfsiii jfsiii mentioned this issue Apr 19, 2021
Merged
jfsiii pushed a commit that referenced this issue Apr 19, 2021
Don't show 'Upgrade available' for agents in hosted policies (#97517)
8db3331 
## Summary
Close item 3 on #91906. Don't show icon & "upgrade available" for agents in hosted agent policies

### Local testing
I'll try to come back and post the exact commands if anyone wants them, but my rough flow was

1. start ES in 7.13
2. checkout kibana 7.x branch and start
3. create agents in kibana
4. stop kibana & ES
5. start ES in 8.0.0-SNAPSHOT
6. switch to kibana `master` branch & start
7. Navigate to http://localhost:5601/app/fleet#/fleet/agents and observe agents with upgrade available
8. assign agent(s) to a hosted agent policy
9. Observe behavior shown in two screenshots
### Don't show "upgrade available" for hosted agents in list
<img width="947" alt="Screen Shot 2021-04-19 at 3 08 12 PM" src="https://user-images.githubusercontent.com/57655/115291869-421c2480-a123-11eb-9dd2-6e450775c16b.png">

### Don't show agent in list when "Upgrade available" filter is selected
<img width="945" alt="Screen Shot 2021-04-19 at 3 08 40 PM" src="https://user-images.githubusercontent.com/57655/115291870-421c2480-a123-11eb-9309-09e3de8902f8.png">


closes #91906
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Apr 19, 2021
@kibanamachine
Don't show 'Upgrade available' for agents in hosted policies (elastic…
5e514c1 
…#97517)

## Summary
Close item 3 on elastic#91906. Don't show icon & "upgrade available" for agents in hosted agent policies

### Local testing
I'll try to come back and post the exact commands if anyone wants them, but my rough flow was

1. start ES in 7.13
2. checkout kibana 7.x branch and start
3. create agents in kibana
4. stop kibana & ES
5. start ES in 8.0.0-SNAPSHOT
6. switch to kibana `master` branch & start
7. Navigate to http://localhost:5601/app/fleet#/fleet/agents and observe agents with upgrade available
8. assign agent(s) to a hosted agent policy
9. Observe behavior shown in two screenshots
### Don't show "upgrade available" for hosted agents in list
<img width="947" alt="Screen Shot 2021-04-19 at 3 08 12 PM" src="https://user-images.githubusercontent.com/57655/115291869-421c2480-a123-11eb-9dd2-6e450775c16b.png">

### Don't show agent in list when "Upgrade available" filter is selected
<img width="945" alt="Screen Shot 2021-04-19 at 3 08 40 PM" src="https://user-images.githubusercontent.com/57655/115291870-421c2480-a123-11eb-9309-09e3de8902f8.png">


closes elastic#91906
kibanamachine added a commit that referenced this issue Apr 19, 2021
@kibanamachine
Don't show 'Upgrade available' for agents in hosted policies (#97517) (…
9844f08 
…#97542)

## Summary
Close item 3 on #91906. Don't show icon & "upgrade available" for agents in hosted agent policies

### Local testing
I'll try to come back and post the exact commands if anyone wants them, but my rough flow was

1. start ES in 7.13
2. checkout kibana 7.x branch and start
3. create agents in kibana
4. stop kibana & ES
5. start ES in 8.0.0-SNAPSHOT
6. switch to kibana `master` branch & start
7. Navigate to http://localhost:5601/app/fleet#/fleet/agents and observe agents with upgrade available
8. assign agent(s) to a hosted agent policy
9. Observe behavior shown in two screenshots
### Don't show "upgrade available" for hosted agents in list
<img width="947" alt="Screen Shot 2021-04-19 at 3 08 12 PM" src="https://user-images.githubusercontent.com/57655/115291869-421c2480-a123-11eb-9dd2-6e450775c16b.png">

### Don't show agent in list when "Upgrade available" filter is selected
<img width="945" alt="Screen Shot 2021-04-19 at 3 08 40 PM" src="https://user-images.githubusercontent.com/57655/115291870-421c2480-a123-11eb-9309-09e3de8902f8.png">


closes #91906

Co-authored-by: John Schulz <john.schulz@elastic.co>
@ruflin
Copy link
Contributor

ruflin commented Apr 20, 2021

@jfsiii Great job on getting all the changes in. For 3, should we also link to the PR and check off the items?

@jfsiii
Copy link
Contributor Author

jfsiii commented Apr 20, 2021

@ruflin thanks. Updated.

@dikshachauhan-qasource
Copy link

Hi @EricDavisX

Today we have updated 03 testcase for new changes available in linked tickets and created 04 testcases for above merged PR. Testcases Link is as follows:

Please let us know if we have missed anything.

Thanks
QAS

@ruflin ruflin mentioned this issue Apr 30, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jfsiii jfsiii

Labels
Team:Fleet Team label for Observability Data Collection Fleet team v7.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fleet] Don't show 'Upgrade available' for agents in hosted policies jfsiii/kibana
7 participants
@ph @jfsiii @ruflin @hbharding @mostlyjason @elasticmachine @dikshachauhan-qasource